Proxy-Wasm mega backport #284
Conversation
|
Skipping CI for Draft Pull Request. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@kyessenov @bianpengyuan I'm still waiting for envoyproxy#13753, envoyproxy#13836 and envoyproxy#13840, but I'd like to get those fixes merged into 1.8 release. |
|
I am not happy about changes in istio/envoy that are not in upstream. I'm not convinced they solve the problem (e.g. the leak is still there AFAICT) and the configuration model change will have unpredictable impact on stats module. Have you validated that they do not destabilize istio/proxy? |
|
@kyessenov Those two unmerged changes are not included in this PR, and yeah agree the change has to be in upstream first. |
|
@bianpengyuan Yes, I didn't read "those" correctly at first. Still many of the changes included here are a build-up to the fixes. They are not needed unless we get the actual fixes. |
|
@kyessenov there are no changes here that are not already merged upstream. I tested with the existing tests in istio/proxy. |
PiotrSikora
force-pushed
the
wasm-1.8
branch
from
4a2ede7
to
9c8aa6e
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
The only outstanding issue is the memory leak (fixed with either envoyproxy#13836 or envoyproxy#13941), everything else is backported here. @bianpengyuan @kyessenov let me know if you want to merge this now, so that we can run tests with this over the weekend, or if you want to wait for the memory leak to be merged first. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
Cherry-picked envoyproxy#13836, so this is now ready to go. @bianpengyuan @kyessenov the question is whether we want to merge envoyproxy#13753 and do extended testing before 1.8.1, or should I remove it from this backport? I originally said that we can drop it, but I'm having second thoughts now. |
|
After some testing, I am worried that wasm extensions that works with 1.8.0 could break with 1.8.1. Is it possible that we can avoid this massive update, especially tool chain and dependencies, and only cherry-pick code fixes? |
|
Is envoyproxy#13753 the reason why we need to make this cherry-pick so bloated? If that is the case I'd rather push that to 1.9 because I don't believe there is user who heavily reconfigures the plugin. |
If you build without sandboxing for performance, the output files from this custom build genrule contained timestamps which caused it to rebuild every single build. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
…y#13858) Fixes envoyproxy#13856. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
…3930) Resolves envoyproxy#13857 ref: -proxy-wasm/proxy-wasm-rust-sdk#44 -proxy-wasm/proxy-wasm-cpp-host#88 -proxy-wasm/proxy-wasm-cpp-host#93 Signed-off-by: mathetake <takeshi@tetrate.io> Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora
force-pushed
the
wasm-1.8
branch
from
074bca6
to
87fd869
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
(removed Emscripten update from the backports) |
PiotrSikora
force-pushed
the
wasm-1.8
branch
from
87fd869
to
ecd2047
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
I dropped a few changes from here (including reconfiguration) now that we have |
|
Test failure seems to be real. |
Fixes proxy-wasm/proxy-wasm-rust-sdk#43. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
PiotrSikora
force-pushed
the
wasm-1.8
branch
from
ecd2047
to
35f5ec9
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
I forgot to revert one of the new tests to the old-style setup with reconfiguration. Fixed now. |
This backport includes Proxy-Wasm C++ Host and SDK updates,
including Emscripten, as well as build and related reliability fixes.