Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Istio auth tutorial #73

Merged
merged 15 commits into from
May 3, 2017
Merged

Istio auth tutorial #73

merged 15 commits into from
May 3, 2017

Conversation

myidpt
Copy link
Contributor

@myidpt myidpt commented Apr 27, 2017

No description provided.

@myidpt myidpt mentioned this pull request Apr 27, 2017
Closed
@wattli
Copy link
Contributor

wattli commented May 1, 2017

@geeknoid , @LisaFC , could you please take a look?

wattli
wattli reviewed May 1, 2017
View reviewed changes
_docs/tasks/istio-auth.md Outdated

## Enabling Istio Auth

### Option 1: Using Per-Namespace CA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Option 1: Using Per-Namespace CA/Option 1: using per-namespace CA

to be consistent with previous section and other docs, e.g., https://istio.io/docs/concepts/what-is-istio/architecture.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

geeknoid
geeknoid suggested changes May 1, 2017
View reviewed changes
_docs/tasks/istio-auth.md Outdated
@@ -1,37 +1,153 @@
---
title: Enabling Istio Auth
overview: This task shows you how to setup Istio-Auth to provide mutual TLS authentication between services.

order: 70

bodyclass: docs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove bodyclass:, no longer needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

_docs/tasks/istio-auth.md Outdated
how to:
* Enable Istio auth
* Disable Istio auth
* Verify Istio auth setups
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setups -> setup

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

_docs/tasks/istio-auth.md Outdated


## Before you begin
* Do this.
* Do this too.
The tutorial assumes you have:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tutorial -> This task

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

_docs/tasks/istio-auth.md Outdated
* Do this.
* Do this too.
The tutorial assumes you have:
* Read the [Istio auth
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and else, please add a blank line between bullet items for better HTML rendering.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

_docs/tasks/istio-auth.md Outdated
* Do this too.
The tutorial assumes you have:
* Read the [Istio auth
concepts](https://istio.io/docs/concepts/network-and-auth/index.html).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and elsewhere, istio.io links shouldn't include https://istio.io. So just /docs/concepts/...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

_docs/tasks/istio-auth.md Outdated

## Doing ...
#### Recovering the Original Config Files
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

original config files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

_docs/tasks/istio-auth.md Outdated
kubectl apply -f ./kubernetes/istio-X.yaml
```

Also, redeploy your applications by running:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applications -> application

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

_docs/tasks/istio-auth.md Outdated
kubectl delete -f ./kubernetes/istio-auth/istio-cluster-ca.yaml
```

#### Redeploying Istio And Applications
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And Applications -> and applications.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

_docs/tasks/istio-auth.md Outdated

### For Per-Cluster CA Istio Auth

#### Removing Per-Cluster Istio CA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per-Cluster -> per-cluster

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

_docs/tasks/istio-auth.md Outdated
kubectl apply -f ./kubernetes/istio-X.yaml
```

Also, redeploy your applications by running:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apllications -> application

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

geeknoid
geeknoid approved these changes May 3, 2017
View reviewed changes
_docs/tasks/istio-auth.md Outdated
@@ -1,36 +1,162 @@
---
title: Enabling Istio Auth
title: Istio Auth
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need a word like "Enabling" or "Installing" in the title. Otherwise, it's not particularly useful in the TOC.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@myidpt
Copy link
Contributor Author

myidpt commented May 3, 2017

@LisaFC @sebastienvas Can any of you take a look and merge this PR if it looks good? Thanks.

@sebastienvas sebastienvas merged commit 767a11c into istio:master May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wattli wattli wattli left review comments

@geeknoid geeknoid geeknoid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@myidpt @wattli @geeknoid @sebastienvas