Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CRD from v1beta1 to v1 #18771

Closed
jasonwzm opened this issue Nov 8, 2019 · 2 comments · Fixed by #25263
Closed

Upgrade CRD from v1beta1 to v1 #18771

jasonwzm opened this issue Nov 8, 2019 · 2 comments · Fixed by #25263
Assignees
Labels
area/config lifecycle/staleproof Indicates a PR or issue has been deemed to be immune from becoming stale and/or automatically closed

Comments

@jasonwzm
Copy link
Member

jasonwzm commented Nov 8, 2019

Upgrade CRDs to v1 and remove the use of v1beta1 CRD client code in Istio.

kubernetes/kubernetes#79604 mentions v1beta1 will not be served starting Kubernetes 1.19. So with the current release cadence, we need to finish it by Istio 1.8.

@jasonwzm jasonwzm self-assigned this Nov 8, 2019
@howardjohn
Copy link
Member

howardjohn commented Nov 8, 2019

so there is only 1.16-1.18 where both are supported? that does give us a pretty tight window... that's say more aggressive than other apis.

We may need to support both options at once, not sure his much effort that would involve

@jasonwzm
Copy link
Member Author

jasonwzm commented Nov 8, 2019

Yes. So we have roughly a year to make this fully work.

Yea, probably a lot of work. They provide conversion funcs which we leverage though.

@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Feb 6, 2020
@jasonwzm jasonwzm added lifecycle/staleproof Indicates a PR or issue has been deemed to be immune from becoming stale and/or automatically closed and removed lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while labels Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config lifecycle/staleproof Indicates a PR or issue has been deemed to be immune from becoming stale and/or automatically closed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants