Go binary size regression

[howardjohn]

Agent:
master: 110m
1.6: 74m
1.5: 68m
1.4: 38m

Pilot:
master: 108m
1.6: 90m
1.5: 84m
1.4: 65m

Measured with

for tag in master 1.6.0 1.5.0 1.4.0; do
    echo $tag
    git checkout $tag
    go build -o /tmp/agent ./pilot/cmd/pilot-discovery
    ll /tmp/agent
    echo
done

My theory is the 1.4 -> 1.5 regression in agent is for gateway SDS (pulls in k8s) and then 1.6 -> master regression is google.golang.org/api/compute/v1

cc @rshriram @kyessenov

[howardjohn]

istio-agent basically imports literally everything now since @costinm put an XDS server in it

[kyessenov]

I think that's strange that the client agent is larger than the service. Go doesn't do a good job at code elimination as well.

[kyessenov]

A minimalistic xDS server (e.g. go-control-plane test server) is around 22MB as a point of reference.

[howardjohn]

We also import literally every proto in xds (including v2 and v4) so we can handle envoyfilters which adds a lot

[ericvn]

@brian-avery Checking against 1.7 branch.

[mandarjog]

Here is the actual effect on memory. Unshared ~= resident - shared.
TLDR;
1.7 Is using ~15 MB per pod more for istio-agent, which I don't think is release blocking.

Istio Version	File size	Resident Memory	Unshared memory	Overage
1.5	68M	55M	15M	0
1.6	74M	55M	17M	2M
1.7	110M	80M	30M	15M

Unshared memory costs increase per pod, whereas shared memory costs increase per node.

[howardjohn]

Can you share the commands you ran? Then we can compare some code changes and see what makes improvements

…

On Tue, Aug 11, 2020, 5:29 PM mandarjog ***@***.***> wrote: Here is the actual effect on memory. Unshared ~= resident - shared. TLDR; 1.7 Is using ~15 MB per pod more for istio-agent, which I don't think is release blocking. Istio Version File size Resident Memory Unshared memory Overage 1.5 68M 55M 15M 0 1.6 74M 55M 17M 2M 1.7 110M 80M 30M 15M Unshared memory costs increase *per pod*, whereas shared memory costs increase *per node*. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#26232 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEYGXI4MZOSMBEHK3WQOVDSAHO7HANCNFSM4PW6A7SQ> .

[howardjohn]

btw -

go 1.14: 101M
go 1.15: 97M

so some small wins..