Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update istio iptables CLI to specify DNS redirection #29908

Merged
merged 4 commits into from
Jan 7, 2021

Conversation

coodie
Copy link
Contributor

@coodie coodie commented Jan 7, 2021

In current state it is impossible to reasonably use dns redirection to agent when imported iptables package is used by other golang module. Environmental variable "ISTIO_META_DNS_CAPTURE" is added as global private module variable forcing potential users of the library to have to set up this variable in environment before their binary is up and running.

This change fixes that problem by simply adding "redirect-dns" option to iptables CLI, making it possible to use dns redirection directly from within go code that imports that package without having to set up environmental variable.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

[ ] Does not have any changes that may affect Istio users.

@istio-policy-bot
Copy link

😊 Welcome @coodie! This is either your first contribution to the Istio istio repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jan 7, 2021
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 7, 2021
@istio-testing
Copy link
Collaborator

Hi @coodie. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn
Copy link
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jan 7, 2021
@coodie coodie requested review from a team as code owners January 7, 2021 18:21
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 7, 2021
@coodie
Copy link
Contributor Author

coodie commented Jan 7, 2021

/retest

Co-authored-by: Eric Van Norman <ericvn@us.ibm.com>
@coodie
Copy link
Contributor Author

coodie commented Jan 7, 2021

/retest

@istio-testing istio-testing merged commit ddbff46 into istio:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants