-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update istio iptables CLI to specify DNS redirection #29908
Conversation
😊 Welcome @coodie! This is either your first contribution to the Istio istio repo, or it's been You can learn more about the Istio working groups, code of conduct, and contributing guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
Hi @coodie. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
Co-authored-by: Eric Van Norman <ericvn@us.ibm.com>
/retest |
In current state it is impossible to reasonably use dns redirection to agent when imported iptables package is used by other golang module. Environmental variable "ISTIO_META_DNS_CAPTURE" is added as global private module variable forcing potential users of the library to have to set up this variable in environment before their binary is up and running.
This change fixes that problem by simply adding "redirect-dns" option to iptables CLI, making it possible to use dns redirection directly from within go code that imports that package without having to set up environmental variable.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Does not have any changes that may affect Istio users.