Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

istioctl: allow missing EDS in proxy-config #47505

Closed
howardjohn opened this issue Oct 20, 2023 · 1 comment · Fixed by #47515
Closed

istioctl: allow missing EDS in proxy-config #47505

howardjohn opened this issue Oct 20, 2023 · 1 comment · Fixed by #47515
Labels
area/user experience

Comments

@howardjohn
Copy link
Member 

$ kubectl exec shell-667d6b4966-5hjnh -- curl localhost:15000/config_dump -s | istioctl pc all -f -
Error: endpoints not found (was include_eds=true used?): config dump has no configuration type type.googleapis.com/envoy.admin.v3.EndpointsConfigDump

Would expect this to just skip the EDS
@hanxiaop
Copy link
Member

Yes, it seems that this shouldn't print an error, since the file is provided with the missing EDS config. I'll submit a fix.

@hanxiaop hanxiaop mentioned this issue Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

istioctl: allow file configdump missing eds for proxy-config hanxiaop/istio
2 participants
@howardjohn @hanxiaop