Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EnvoyFilter: http Route match #16146

Merged
merged 13 commits into from Aug 9, 2019
Merged

EnvoyFilter: http Route match #16146

merged 13 commits into from Aug 9, 2019

Conversation

rshriram
Copy link
Member

@rshriram rshriram commented Aug 8, 2019 •
edited

Implements ability to match on HTTP Routes.

Singed-off-by: Shriram Rajagopalan rshriram@tetrate.io

@rshriram
add names to http routes
cbbedeb 
Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io>
@rshriram
vendor
a73453e
@rshriram
adding HTTP_ROUTES
b0d0ddd 
Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io>
@rshriram
Merge branch 'named_routes' into envoyfilter_route
ab7592a
@rshriram
Merge branch 'master' of https://github.com/istio/istio into envoyfil…
7f16566 
…ter_route
@istio-testing istio-testing added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 8, 2019
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Aug 8, 2019
golangcibot
golangcibot reviewed Aug 8, 2019
View reviewed changes
pilot/pkg/networking/core/v1alpha3/route/route.go Outdated
@@ -331,6 +334,15 @@ func translateRoute(push *model.PushContext, node *model.Proxy, in *networking.H
Metadata: util.BuildConfigInfoMetadata(virtualService.ConfigMeta),
}


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File is not gofmt-ed with -s (from gofmt)

Suggested change

pilot/pkg/networking/core/v1alpha3/envoyfilter/rc_patch_test.go Outdated
@@ -285,6 +324,24 @@ func TestApplyRouteConfigurationPatches(t *testing.T) {
{
Name: "foo.com",
Domains: []string{"domain"},
Routes: []*route.Route{
{
Name: "foo",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File is not gofmt-ed with -s (from gofmt)

pilot/pkg/networking/core/v1alpha3/envoyfilter/rc_patch.go Outdated
doHttpRouteListOperation(proxy, patchContext, patches, routeConfiguration, virtualHost)
}

func doHttpRouteListOperation(proxy *model.Proxy, patchContext networking.EnvoyFilter_PatchContext,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

func doHttpRouteListOperation should be doHTTPRouteListOperation (from golint)

pilot/pkg/networking/core/v1alpha3/envoyfilter/rc_patch.go Outdated
}
}

func doHttpRouteOperation(proxy *model.Proxy, patchContext networking.EnvoyFilter_PatchContext,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

func doHttpRouteOperation should be doHTTPRouteOperation (from golint)

@rshriram
lint and fixes
5ceed25 
Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io>
@rshriram
compile fixes
858e4e5 
Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io>
@rshriram
fixes
ba3f34d 
Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io>
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Aug 8, 2019
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Aug 8, 2019
@rshriram
more fixes
ed15fe5 
Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io>
@rshriram
fixes
9bccbe3 
Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io>
@rshriram
Merge branch 'master' of https://github.com/istio/istio into envoyfil…
11bf415 
…ter_route
@rshriram
final fix
f49f668 
Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io>
@istio-testing
Copy link
Collaborator

@rshriram: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
istio-pilot-multicluster-e2e-master f49f668 link /test istio-pilot-multicluster-e2e-master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram rshriram merged commit fc69f3d into istio:master Aug 9, 2019
tobiasgiese pushed a commit to c445/istio that referenced this pull request Aug 13, 2019
@rshriram @tobiasgiese
EnvoyFilter: http Route match (istio#16146)
16b2ccf 
* add names to http routes

Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io>

* vendor

* adding HTTP_ROUTES

Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io>

* lint and fixes

Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io>

* compile fixes

Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io>

* fixes

Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io>

* more fixes

Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io>

* fixes

Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io>

* final fix

Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io>
@rshriram rshriram deleted the envoyfilter_route branch December 6, 2019 19:03
howardjohn added a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
@howardjohn @mergify
Sync changes to old installer (istio#316)
9258a84 
* Sync changes to old installer

Cherrypicks istio#13392, istio#13666, istio#13982, istio#14077, istio#14059

* Cherrypick istio#14301

* Cherrypick istio#13638

* cherrypick istio#14606

* istio#14171

* istio#14438

* istio#14674

* istio#14974

* 14904

* istio#14796

* istio#15346

* istio#15345

* istio#15383

* istio#14815

* istio#15690

* istio#15681

* istio#15014

* istio#15503

* istio#16084

* istio#16146

* istio#16147

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@GregHanson GregHanson GregHanson approved these changes

@andraxylia andraxylia Awaiting requested review from andraxylia

@costinm costinm Awaiting requested review from costinm costinm is a code owner

@diemtvu diemtvu Awaiting requested review from diemtvu

@geeknoid geeknoid Awaiting requested review from geeknoid

@howardjohn howardjohn Awaiting requested review from howardjohn howardjohn is a code owner

@linsun linsun Awaiting requested review from linsun linsun is a code owner

@nmittler nmittler Awaiting requested review from nmittler

@ostromart ostromart Awaiting requested review from ostromart

@ozevren ozevren Awaiting requested review from ozevren

@vadimeisenbergibm vadimeisenbergibm Awaiting requested review from vadimeisenbergibm

@ZackButcher ZackButcher Awaiting requested review from ZackButcher

@mandarjog mandarjog Awaiting requested review from mandarjog

@morvencao morvencao Awaiting requested review from morvencao

@sdake sdake Awaiting requested review from sdake

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rshriram @istio-testing @hzxuzhonghu @GregHanson @golangcibot @googlebot