Remove trustworthy and legacy jwt concepts. Always use trustworthy jwt #16147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
do-not-merge/work-in-progress
googlebot
added
the
cla: yes
istio-testing
added
the
size/L
golangcibot
reviewed
Aug 8, 2019
pitlv2109
force-pushed
the
remove-normalJwt-key
branch
from
e00a07a
to
7b5f655
Compare
pitlv2109
force-pushed
the
remove-normalJwt-key
branch
from
7b5f655
to
c3ea331
Compare
|
@pitlv2109: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
pitlv2109
changed the title
pitlv2109
requested review from
andraxylia,
costinm,
diemtvu,
GregHanson,
howardjohn,
hzxuzhonghu and
incfly
as code owners
istio-testing
removed
the
do-not-merge/work-in-progress
pitlv2109
requested review from
JimmyCYJ,
linsun,
mandarjog,
morvencao,
myidpt,
nmittler,
ostromart,
ozevren,
quanjielin,
rshriram,
sdake and
vadimeisenbergibm
as code owners
pitlv2109
requested review from
wattli,
yangminzhu and
ZackButcher
as code owners
|
@quanjielin @myidpt Hopefully we can land this in 1.3. PTAL. |
|
are we removing this in 1.3? We don't have a deprecation time period for this? Or was it already deprecated? |
We've already removed it. This is just a cleanup. Trustworthy Jwt is the only choice when using SDS. |
rshriram
approved these changes
Aug 9, 2019
tobiasgiese
pushed a commit
to c445/istio
that referenced
this pull request
Aug 13, 2019
5 tasks
lei-tang
added a commit
to lei-tang/istio.github.io
that referenced
this pull request
Sep 3, 2019
…ease 1.3 Istio release 1.3 uses new k8s JWT (istio/istio#16147), which breaks the user guide of Istio Vault CA integration for release 1.3. This PR temporarily disables the user guide of Istio Vault CA integration for release 1.3.
lei-tang
added a commit
to lei-tang/istio.github.io
that referenced
this pull request
Sep 5, 2019
…ease 1.3 Istio release 1.3 uses new k8s JWT (istio/istio#16147), which breaks the user guide of Istio Vault CA integration for release 1.3. This PR temporarily disables the user guide of Istio Vault CA integration for release 1.3.
geeknoid
pushed a commit
to istio/istio.io
that referenced
this pull request
Sep 6, 2019
…ration for release 1.3 (#4904) * Temporarily disable the user guide of Istio Vault integration for release 1.3 Istio release 1.3 uses new k8s JWT (istio/istio#16147), which breaks the user guide of Istio Vault CA integration for release 1.3. This PR temporarily disables the user guide of Istio Vault CA integration for release 1.3.
howardjohn
added a commit
to howardjohn/istio
that referenced
this pull request
Jan 12, 2020
* Sync changes to old installer Cherrypicks istio#13392, istio#13666, istio#13982, istio#14077, istio#14059 * Cherrypick istio#14301 * Cherrypick istio#13638 * cherrypick istio#14606 * istio#14171 * istio#14438 * istio#14674 * istio#14974 * 14904 * istio#14796 * istio#15346 * istio#15345 * istio#15383 * istio#14815 * istio#15690 * istio#15681 * istio#15014 * istio#15503 * istio#16084 * istio#16146 * istio#16147 * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
useTrustworthyJwtanduseNormalJwthelm values. Always use trustworthy Jwts if SDS is enabled.[ ] Configuration Infrastructure
[ ] Docs
[X] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[X] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure