Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CronJobs already GA in k8s V1.21 #33966

Closed
wants to merge 1 commit into from

Conversation

ChenglongGao327
Copy link
Member

@ChenglongGao327 ChenglongGao327 commented Jul 12, 2021

The latest version of Cronjob is batch/v1, which is GA in version 1.21 of k8s
it can be derived from pod metadata

k8s PR:Switch cronjob controller to batch/v1
kubernetes/kubernetes#99423

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

The latest version of Cronjob is batch/v1, which is GA in version 1.21 of k8s

k8s PR: Promote CronJobs to batch/v1
kubernetes/kubernetes#98965
@ChenglongGao327 ChenglongGao327 requested a review from a team as a code owner July 12, 2021 07:27
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 12, 2021
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jul 12, 2021
@istio-testing
Copy link
Collaborator

istio-testing commented Jul 12, 2021

@ChenglongGao327: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
release-notes_istio 04282a9 link /test release-notes_istio

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ChenglongGao327
Copy link
Member Author

cc @bianpengyuan

Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will this impact users not on 1.21? Most are not yet

@bianpengyuan
Copy link
Contributor

bianpengyuan commented Jul 12, 2021

How will this impact users not on 1.21? Most are not yet

+1, Also I think we will need to replace it, not removing it? But anyway, let's wait until istio support window covers 1.21+ or majority of user is on 1.21+ before making this change, which could take a while..

@ChenglongGao327
Copy link
Member Author

ChenglongGao327 commented Jul 13, 2021

How will this impact users not on 1.21? Most are not yet

+1, Also I think we will need to replace it, not removing it? But anyway, let's wait until istio support window covers 1.21+ or majority of user is on 1.21+ before making this change, which could take a while..

I just found this, not sure when to modify cronjob to use v1 version. Proxy can be injected in an environment where k8s is 1.17.
Other effects are uncertain

@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Aug 12, 2021
@istio-policy-bot
Copy link

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2021-07-13. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants