-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CronJobs already GA in k8s V1.21 #33966
Conversation
The latest version of Cronjob is batch/v1, which is GA in version 1.21 of k8s k8s PR: Promote CronJobs to batch/v1 kubernetes/kubernetes#98965
@ChenglongGao327: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will this impact users not on 1.21? Most are not yet
+1, Also I think we will need to replace it, not removing it? But anyway, let's wait until istio support window covers 1.21+ or majority of user is on 1.21+ before making this change, which could take a while.. |
I just found this, not sure when to modify cronjob to use v1 version. Proxy can be injected in an environment where k8s is 1.17. |
🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2021-07-13. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions. Created by the issue and PR lifecycle manager. |
The latest version of Cronjob is batch/v1, which is GA in version 1.21 of k8s
it can be derived from pod metadata
k8s PR:Switch cronjob controller to batch/v1
kubernetes/kubernetes#99423
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.