-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch cronjob controller to batch/v1 #99423
Conversation
/triage accepted |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
/test pull-kubernetes-conformance-kind-ipv6-parallel |
@soltysh: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3748681
to
87c785f
Compare
87c785f
to
78f51f8
Compare
/test pull-kubernetes-unit |
2 similar comments
/test pull-kubernetes-unit |
/test pull-kubernetes-unit |
/lgtm |
/lgtm Split #99197 into two PRs:
Once this merges, we'll merge the "switch e2e to v1" PR and let the "promote to conformance" PR soak for two weeks before merging |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alaypatel07, liggitt, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@soltysh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test pull-kubernetes-e2e-kind |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This promotes
CronJob
controller to usebatch/v1
based on kubernetes/enhancements#19 and complete description from https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/19-Graduate-CronJob-to-StableSpecial notes for your reviewer:
This builds on top of #98965 so only the last commit matters.
/assign @deads2k @liggitt
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: