Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote CronJobs to batch/v1 #98965

Closed
wants to merge 8 commits into from
Closed

Promote CronJobs to batch/v1 #98965

wants to merge 8 commits into from

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Feb 10, 2021 •
edited by liggitt

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

This promotes CronJob resource to batch/v1 based on kubernetes/enhancements#19 and complete description from https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/19-Graduate-CronJob-to-Stable

Which issue(s) this PR fixes:
Fixes #90473

Special notes for your reviewer:

/assign @deads2k @liggitt

Does this PR introduce a user-facing change?

The CronJob API is promoted to batch/v1. The batch/v1beta1 API version is deprecated and will no longer be served in 1.25.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/19-Graduate-CronJob-to-Stable

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 10, 2021
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 10, 2021
@soltysh
Copy link
Contributor Author

soltysh commented Feb 10, 2021

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 10, 2021
@soltysh
Copy link
Contributor Author

soltysh commented Feb 10, 2021

/retest

@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 12, 2021
@soltysh
Copy link
Contributor Author

soltysh commented Feb 12, 2021

/label api-review

@k8s-ci-robot k8s-ci-robot added api-review Categorizes an issue or PR as actively needing an API review. area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Feb 12, 2021
@soltysh
Copy link
Contributor Author

soltysh commented Mar 4, 2021

Github complained, so I rebased those.

@soltysh soltysh removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2021
@soltysh
Copy link
Contributor Author

soltysh commented Mar 4, 2021

/test pull-kubernetes-e2e-kind

@k8s-ci-robot
Copy link
Contributor

@soltysh: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

4 similar comments
@k8s-ci-robot
Copy link
Contributor

@soltysh: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@soltysh: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@soltysh: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@soltysh: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@desponda
Copy link

desponda commented Mar 5, 2021

👋 Hello! I am from the Bug Triage team! Friendly reminder that code freeze is starting March 9th, 2021 (about 1 week from now)!

@liggitt
Copy link
Member

liggitt commented Mar 5, 2021

API bits lgtm. Let me know when the controller and e2e PRs are ready and we'll traffic direct these in.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Contributor Author

soltysh commented Mar 5, 2021

/test pull-kubernetes-unit

@soltysh
Copy link
Contributor Author

soltysh commented Mar 5, 2021

/test pull-kubernetes-unit
/test pull-kubernetes-e2e-gce-ubuntu-containerd

@liggitt
Copy link
Member

liggitt commented Mar 5, 2021

lgtm + approve

will merge these changes as part of #99423 (comment)

@liggitt liggitt closed this Mar 5, 2021
@soltysh soltysh deleted the cronjob_v1 branch March 5, 2021 17:54
@soltysh soltysh mentioned this pull request Mar 5, 2021
Merged
ChenglongGao327 added a commit to ChenglongGao327/istio that referenced this pull request Jul 12, 2021
@ChenglongGao327
CronJobs already GA in k8s 1.21
04282a9 
The latest version of Cronjob is batch/v1, which is GA in version 1.21 of k8s

k8s PR: Promote CronJobs to batch/v1
kubernetes/kubernetes#98965
@ChenglongGao327 ChenglongGao327 mentioned this pull request Jul 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@alculquicondor alculquicondor alculquicondor left review comments

@apelisse apelisse apelisse left review comments

@tengqm tengqm tengqm left review comments

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@liggitt liggitt

@deads2k deads2k

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl area/test area/workload-api/cronjob cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.21
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

batch v1beta1 will be deprecated in 1.22
9 participants
@soltysh @fejta-bot @liggitt @k8s-ci-robot @desponda @alculquicondor @apelisse @tengqm @deads2k