Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor pilot-config-monitor #8371

Merged
merged 1 commit into from
Sep 6, 2018
Merged

Conversation

knightXun
Copy link
Contributor

refactor config compare function

@ymesika
Copy link
Member

ymesika commented Aug 30, 2018

/ok-to-test

Copy link
Contributor

@costinm costinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov
Copy link

codecov bot commented Sep 3, 2018

Codecov Report

Merging #8371 into master will increase coverage by 1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #8371    +/-   ##
=======================================
+ Coverage      72%     72%    +1%     
=======================================
  Files         377     377            
  Lines       33077   32906   -171     
=======================================
- Hits        23633   23530   -103     
+ Misses       8433    8352    -81     
- Partials     1011    1024    +13
Impacted Files Coverage Δ
pilot/pkg/config/monitor/monitor.go 78% <100%> (ø) ⬇️
...olarwinds/internal/papertrail/papertrail_logger.go 62% <0%> (-18%) ⬇️
mixer/adapter/stackdriver/stackdriver.go 50% <0%> (-4%) ⬇️
pilot/pkg/serviceregistry/kube/queue.go 84% <0%> (-4%) ⬇️
pilot/pkg/serviceregistry/consul/monitor.go 81% <0%> (-4%) ⬇️
mixer/adapter/rbac/rbacStore.go 77% <0%> (-3%) ⬇️
mixer/adapter/opa/opa.go 79% <0%> (-1%) ⬇️
pilot/pkg/serviceregistry/kube/controller.go 66% <0%> (ø) ⬇️
mixer/pkg/protobuf/yaml/dynamic/primitive.go 98% <0%> (ø) ⬇️
mixer/adapter/dogstatsd/dogstatsd.go 100% <0%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad7e902...388275d. Read the comment docs.

@knightXun
Copy link
Contributor Author

/test e2e-mixer-no_auth

Copy link
Member

@rshriram rshriram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: costinm, rshriram

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knightXun
Copy link
Contributor Author

/test istio-unit-tests

@istio-testing istio-testing merged commit 9094680 into istio:master Sep 6, 2018
@knightXun knightXun deleted the monitor branch September 6, 2018 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants