Update dependency to fix goroutine proliferation in zipkin-go #1515
Conversation
|
collected some data points for this PR -- in short, this seems solving the reported problem (istio/old_issues_repo#100). My setup is to simply deploy the istio-auth (without zipkin pod), bookinfo sample, and run The red line in the following graph shows the heap alloc bytes data (tracked by prometheus), with this PR (green is proxy -- unrelated, same in the following graphs): Without this PR, typically heap allocation looks like note that the spiky pattern happens after wrk run finishes -- still using memory for zipkin, we guess. The number of goroutines, Still have some increases since gRPC creates a goroutine for every request, but actually, the goroutine count looks like as follows without this PR and note that, with the scale of the latter graph, the former goroutine "increase" looks like a flat line. |
|
/lgtm |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: douglas-reid, jmuk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Codecov Report
@@ Coverage Diff @@
## master #1515 +/- ##
=======================================
Coverage 84.58% 84.58%
=======================================
Files 122 122
Lines 11999 11999
=======================================
Hits 10149 10149
Misses 1648 1648
Partials 202 202Continue to review full report at Codecov.
|
…1515) Automatic merge from submit-queue. Update dependency to fix goroutine proliferation in zipkin-go This PR fixes goroutine proliferation issue with openzipkin-go. istio/old_issues_repo#100 (comment) After the PR is upstreamed, we will update the dependency. mandarjog/zipkin-go-opentracing#1 **Release note**: ```release-note NONE ```
…#1516) Automatic merge from submit-queue. Update dependency to fix goroutine proliferation in zipkin-go This PR fixes goroutine proliferation issue with openzipkin-go. istio/old_issues_repo#100 (comment) After the PR is upstreamed, we will update the dependency. mandarjog/zipkin-go-opentracing#1 **Release note**: ```release-note NONE ```
This PR fixes goroutine proliferation issue with openzipkin-go.
istio/old_issues_repo#100 (comment)
After the PR is upstreamed, we will update the dependency.
mandarjog/zipkin-go-opentracing#1
Release note:
This change is