This repository has been archived by the owner on Jun 14, 2018. It is now read-only.
Remove sleeps in integration test #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayj
reviewed
Feb 17, 2017
test/integration/driver.go
Outdated
| return nil | ||
| } | ||
| time.Sleep(1 * time.Second) | ||
| n++ |
There was a problem hiding this comment.
'n' is incremented twice per loop: once here and once in the 'for' post statement one line 465
kyessenov
approved these changes
Feb 17, 2017
…poch has been incremented.
|
Jenkins job manager/presubmit passed |
ijsnellf
changed the title
|
Jenkins job manager/presubmit passed |
This was referenced Feb 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the sleep inside the integration tests with Envoy restart epoch checks that wait until the epoch has been incremented.
Also re-enables fault tests, since this change should make them more reliable.