Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rotate the scopes to support metrics expiry #4427

Closed
wants to merge 1 commit into from
Closed

rotate the scopes to support metrics expiry #4427

wants to merge 1 commit into from

Conversation

ZhengzheYang
Copy link

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Feb 10, 2023
@istio-testing
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@istio-policy-bot
Copy link

😊 Welcome @ZhengzheYang! This is either your first contribution to the Istio proxy repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 10, 2023
@ZhengzheYang
Copy link
Author

/test all

@ZhengzheYang
Copy link
Author

/test all

@ZhengzheYang
Copy link
Author

/retest

@ZhengzheYang
Copy link
Author

/test all

@ZhengzheYang
Copy link
Author

/test all

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Feb 24, 2023
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Feb 24, 2023
@ZhengzheYang
Copy link
Author

/test all

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Feb 28, 2023
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Mar 2, 2023
@ZhengzheYang
Copy link
Author

/test all

@ZhengzheYang
Copy link
Author

/retest

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Mar 29, 2023
@istio-testing
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyessenov kyessenov mentioned this pull request Apr 19, 2023
Merged
@kyessenov
Copy link
Contributor

Implemented in #4597

@kyessenov kyessenov closed this Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. needs-rebase Indicates a PR needs to be rebased before being merged size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZhengzheYang @istio-testing @istio-policy-bot @kyessenov