Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prow: when job running, link to prow/deck logs #344

Closed
nlandolfi opened this issue Jul 28, 2017 · 3 comments
Closed

prow: when job running, link to prow/deck logs #344

nlandolfi opened this issue Jul 28, 2017 · 3 comments
Assignees

Comments

@nlandolfi
Copy link
Contributor

I propose that we customize the link posted with different Prow job statuses.

I have the following use case in mind:

...job starts...
plank posts to Github with the prow/deck logs link
...the job completes...
plank posts to Github with the gubernator job link. 
@nlandolfi nlandolfi self-assigned this Jul 28, 2017
@nlandolfi
Copy link
Contributor Author

At present, this depends upon kubernetes/test-infra#3876 going to master in kubernetes/test-infra, and then us re-writing the plank_url template in the prow/config.yaml to direct to https://prow.istio.io while the job is running, and to where it currently directs (Gubernator) after the job has completed.

@sebastienvas sebastienvas added this to the Istio 0.2 milestone Aug 17, 2017
@sakshigoel12 sakshigoel12 modified the milestones: Istio 0.2, Istio 0.3 Sep 28, 2017
@fejta
Copy link
Contributor

fejta commented Aug 6, 2019

/close

We are now linking to deck

@istio-testing
Copy link
Collaborator

@fejta: Closing this issue.

In response to this:

/close

We are now linking to deck

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soloio-bot pushed a commit to soloio-bot/test-infra that referenced this issue Jun 22, 2023
…7679d8 (istio#344)

Co-authored-by: Daniel Hawton <daniel.hawton@solo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants