Adds a method to setup testing cluster #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a test. |
|
Jenkins job istio-testing/pr-master passed |
ayj
reviewed
Mar 16, 2017
| @@ -111,6 +111,16 @@ def sendNotification(notify_list) { | |||
| sendToIndividuals : true]) | |||
| } | |||
|
|
|||
| // init Testing Cluster. | |||
| def initTestingCluster() { | |||
| def cluster = failIfNullOrEmpty(env.E2E_CLUSTER, 'E2E_CLUSTER is not set') | |||
There was a problem hiding this comment.
LGTM functionally.
General question: do tests have full authorization inside the cluster? Could someone submit a PR with code that modifies gcloud settings since this seems to grant full authorization inside the cluster?
There was a problem hiding this comment.
Yes. We will limit test on PR to people in istio org.
There was a problem hiding this comment.
I just did that. Now only people from org can test PR
|
This is a test. |
|
Jenkins job istio-testing/pr-master passed |
|
rebuild mixer/presubmit |
|
This is a test. |
|
Jenkins job istio-testing/pr-master passed |
|
rebuild istio-testing/pr-master |
|
This is a test. |
|
Jenkins job istio-testing/pr-master passed |
ayj
approved these changes
Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.