Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recent buf update fails make gen on Macs and Pipeline - reverting #2389

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Recent buf update fails make gen on Macs and Pipeline - reverting #2389

merged 1 commit into from
Feb 22, 2023

Conversation

ericvn
Copy link
Contributor

@ericvn ericvn commented Feb 22, 2023

make gen with current image has this on Macs:

HEAD is now at c3fb44b4 Automator: update common-files@master in istio/api@master (#2689)
buf generate --config tools/proto/buf.yaml --path operator/pkg/ --output operator  --template tools/proto/buf.golang.yaml
Failure: plugin go-grpc: exec: "": executable file not found in $PATH
make[1]: *** [tools/proto/proto.mk:20: operator-proto] Error 1
make: *** [gen] Error 2

Tried using yesterday's image and things work. Reverting buf.

@ericvn ericvn requested a review from a team as a code owner February 22, 2023 20:28
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 22, 2023
@ericvn
Copy link
Contributor Author

ericvn commented Feb 22, 2023

/test containers-test-arm64

@ericvn
Copy link
Contributor Author

ericvn commented Feb 22, 2023

Looks like the pipeline is also broke...

@ericvn ericvn changed the title Recent buf update fails make gen on Macs - reverting Recent buf update fails make gen on Macs and Pipeline - reverting Feb 22, 2023
@ericvn
Copy link
Contributor Author

ericvn commented Feb 22, 2023

/test containers-test-arm64

@ericvn
Copy link
Contributor Author

ericvn commented Feb 22, 2023

/test containers-test-arm64

2 similar comments
@ericvn
Copy link
Contributor Author

ericvn commented Feb 22, 2023

/test containers-test-arm64

@jacob-delgado
Copy link
Contributor

/test containers-test-arm64

@istio-testing istio-testing merged commit 8c1b105 into istio:master Feb 22, 2023
@ericvn ericvn deleted the fixBuf branch February 22, 2023 21:47
shalier pushed a commit to shalier/tools that referenced this pull request Feb 13, 2024
@shalier
Recent buf update fails make gen on Macs - reverting (istio#2389)
c2de599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacob-delgado jacob-delgado jacob-delgado approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericvn @jacob-delgado @istio-testing