Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#769 refarch refactoring #1207

Merged
merged 5 commits into from
Jan 18, 2024
Merged

Conversation

lehju
Copy link
Contributor

@lehju lehju commented Jan 15, 2024

Description

Update graceful shutdown probes and remove old code.
Add error mapping config map to 500.

Reference

Issues: closes #769

Check-List

  • All Acceptance criteria of user story are met
  • JUnit tests are written (60% CodeCov)
  • Internal Review is maintained
  • Documentations external and internal are completed
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No Branch waste left
  • Board is up-to-date
  • Openshift environments are prepared (Secrets, etc.) and release-issue is maintained

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6801334) 38.52% compared to head (1a69043) 38.88%.
Report is 3 commits behind head on dev.

Files Patch % Lines
...ateway/filter/GlobalAuthenticationErrorFilter.java 95.00% 0 Missing and 1 partial ⚠️
...wf/gateway/filter/GlobalBackend5xxTo400Mapper.java 96.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #1207      +/-   ##
============================================
+ Coverage     38.52%   38.88%   +0.36%     
+ Complexity     1310     1308       -2     
============================================
  Files           599      595       -4     
  Lines          8678     8659      -19     
  Branches        424      424              
============================================
+ Hits           3343     3367      +24     
+ Misses         5197     5153      -44     
- Partials        138      139       +1     
Flag Coverage Δ
unittests 38.88% <96.15%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lehju lehju merged commit a53f00b into dev Jan 18, 2024
7 checks passed
@lehju lehju deleted the feature/#769-refarch-refactoring branch January 18, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ref Arch refactoring
2 participants