Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate Hibernate ID-Pool #1527

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Deactivate Hibernate ID-Pool #1527

merged 1 commit into from
Apr 8, 2024

Conversation

darenegade
Copy link
Member

@darenegade darenegade commented Apr 2, 2024

Description

Disable Hibernate ID-Pool to prevent Axon global index from getting out of sync on multiple instances

Reference

Issues: #1251

Screenshots (If UI changed)

Check-List

  • All Acceptance criteria of user story are met
  • Accessibility was considered and tested (On UI Change)
  • JUnit tests are written (60% CodeCov)
  • Internal Review is maintained
  • Documentations external and internal are completed
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No waste on Branch left (e.g. console.logs)
  • Board is up-to-date
  • Openshift environments are prepared (Secrets, etc.) and release-issue is maintained

@darenegade
Copy link
Member Author

MR wartet noch auf erfolgreiche Rückmeldung zum Fix auf Processes

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.15%. Comparing base (28b94b0) to head (260f9a6).

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #1527   +/-   ##
=========================================
  Coverage     43.15%   43.15%           
  Complexity     1625     1625           
=========================================
  Files           646      646           
  Lines          9448     9448           
  Branches        460      460           
=========================================
  Hits           4077     4077           
  Misses         5204     5204           
  Partials        167      167           
Flag Coverage Δ
unittests 43.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darenegade darenegade marked this pull request as ready for review April 4, 2024 07:39
@darenegade darenegade mentioned this pull request Apr 5, 2024
7 tasks
@simonhir simonhir removed the request for review from zambrovski April 8, 2024 07:48
Copy link
Member

@simonhir simonhir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darenegade darenegade merged commit a757fc8 into dev Apr 8, 2024
21 checks passed
@darenegade darenegade deleted the fix/hibernate_sequence branch April 8, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working digiwf-engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants