-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
@@ -6,7 +6,7 @@ | |||
<parent> | |||
<artifactId>digiwf-email-integration-parent</artifactId> | |||
<groupId>io.muenchendigital.digiwf</groupId> | |||
<version>0.0.2</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super Job 👍
Wollen wir ein Issue machen, um es ins monorepo zu migrieren?
@@ -5,7 +5,7 @@ | |||
<parent> | |||
<artifactId>digiwf-email-integration-parent</artifactId> | |||
<groupId>io.muenchendigital.digiwf</groupId> | |||
<version>0.0.2</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.1.0
import javax.validation.*; | ||
import java.io.InputStream; | ||
import java.net.URL; | ||
import java.util.Set; | ||
|
||
@Slf4j | ||
@AllArgsConstructor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
if (StringUtils.isNotEmpty(exceptionText)) { | ||
throw new MissingInformationMailException(exceptionText.toString()); | ||
public void sendMail(final Mail mail) throws RuntimeException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Valid Mail mail
throw new MissingInformationMailException(exceptionText.toString()); | ||
public void sendMail(final Mail mail) throws RuntimeException { | ||
// validation | ||
final Validator validator = this.validatorFactory.getValidator(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kannst du weglassen, wenn du @Validated
und @Valid
machst.
docs/sendMail.json
Outdated
@@ -140,9 +149,10 @@ | |||
"value": "", | |||
"description": "Create an array with json.array('','') (not yet implemented)", | |||
"binding": { | |||
"type": "camunda:in", | |||
"type": "camunda:inputParameter", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warum inputParameter? ist doch für eine CallActivity oder?
@@ -6,7 +6,7 @@ | |||
<parent> | |||
<artifactId>digiwf-email-integration-parent</artifactId> | |||
<groupId>io.muenchendigital.digiwf</groupId> | |||
<version>0.0.2</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.1.0
@dominikhorn93 Danke für die Review 😃 Eine Issue bzw. Epic habe ich schon erstellt. Ich bereite das für das Planning noch ein wenig auf. |
logging.level.io.muenchendigital=info | ||
logging.level.org.springframework=info | ||
spring.cloud.stream.kafka.binder.brokers=localhost:9092 | ||
#spring.cloud.stream.kafka.binder.brokers=dwf-cluster-kafka-tls-bootstrap-lhmeventbus.apps.capk.muenchen.de:443 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is lhm specific and should be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other lines within this properties files are specific too
@@ -17,35 +14,30 @@ | |||
import javax.mail.Message; | |||
import javax.mail.internet.InternetAddress; | |||
import javax.mail.util.ByteArrayDataSource; | |||
import javax.validation.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wild card imports should be avoided
logging.level.io.muenchendigital=info | ||
logging.level.org.springframework=info | ||
spring.cloud.stream.kafka.binder.brokers=localhost:9092 | ||
#spring.cloud.stream.kafka.binder.brokers=dwf-cluster-kafka-tls-bootstrap-lhmeventbus.apps.capk.muenchen.de:443 | ||
io.muenchendigital.digiwf.engineTopic=dwf-digiwf-engine-local-01 | ||
io.muenchendigital.digiwf.email.topic=dwf-email-local-01 | ||
io.muenchendigital.digiwf.email.group="dwf-email-local-01" | ||
# default email settings for mailhog | ||
spring.mail.host=localhost | ||
spring.mail.port=1025 | ||
spring.mail.username=itm.digitalwf-test@muenchen.de | ||
spring.mail.password=test | ||
spring.mail.properties.mail.debug=false | ||
spring.mail.properties.mail.tls=false | ||
spring.mail.properties.mail.transport.protocol=smtp | ||
spring.mail.properties.mail.smtp.host=localhost | ||
spring.mail.properties.mail.smtp.port=1025 | ||
spring.mail.properties.mail.smtp.connectiontimeout=1000000 | ||
spring.mail.properties.mail.smtp.timeout=1000000 | ||
spring.mail.properties.mail.smtp.auth=false | ||
spring.mail.properties.mail.smtp.ssl.trust="*" | ||
spring.mail.properties.mail.smtp.ssl.checkserveridentity=false | ||
spring.mail.properties.mail.smtp.socketFactory.fallback=true | ||
spring.mail.properties.mail.smtp.starttls.enable=false | ||
io.muenchendigital.digiwf.mail.fromAddress=itm.digitalwf-test@muenchen.de |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove lhm specific prop values
@@ -126,8 +134,9 @@ | |||
"type": "String", | |||
"value": "", | |||
"binding": { | |||
"type": "camunda:in", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Da gilt doch für alle Inputs oder?
Verstehe nicht warum die auf inputParameter sind.
Dadurch landen die ja nicht im StreamingTemplate oder verstehe ich das gerade falsch?
Noch eine Frage zum Element Template
name: Pull request
about: Contribute your changes to the project
title: '[pull-request]'
labels: ''
assignees: ''
Description
Reference
Issues #23
Checklist