Skip to content
This repository has been archived by the owner on Mar 22, 2024. It is now read-only.

Feat/projectspecific s3 #25

Merged
merged 13 commits into from
Oct 19, 2022
Merged

Feat/projectspecific s3 #25

merged 13 commits into from
Oct 19, 2022

Conversation

lmoesle
Copy link
Contributor

@lmoesle lmoesle commented Oct 5, 2022


name: Pull request
about: Contribute your changes to the project
title: '[pull-request]'
labels: ''
assignees: ''

Description

  • Download email attachments from given presigned urls
  • Refactoring: Use javax.validation to validate event bus messages
  • Improve dev environment

Reference
Issues #23

Checklist

  • Acceptance criteria are met
  • Pipeline has been run successfully
  • JUnit tests have been run successfully
  • Changelog is adjusted
  • Documentations are completed
  • Frontend is tested
  • Created sub-branches are deleted
  • Boards are updated ( Digitalisierung , Support , Zenhub )
  • feature process is created or extended
  • git-ops is customized
  • Openshift environments are prepared (Secrets, etc.)

@@ -6,7 +6,7 @@
<parent>
<artifactId>digiwf-email-integration-parent</artifactId>
<groupId>io.muenchendigital.digiwf</groupId>
<version>0.0.2</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.1.0

Copy link
Contributor

@dominikhorn93 dominikhorn93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super Job 👍

Wollen wir ein Issue machen, um es ins monorepo zu migrieren?

@@ -5,7 +5,7 @@
<parent>
<artifactId>digiwf-email-integration-parent</artifactId>
<groupId>io.muenchendigital.digiwf</groupId>
<version>0.0.2</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.1.0

import javax.validation.*;
import java.io.InputStream;
import java.net.URL;
import java.util.Set;

@Slf4j
@AllArgsConstructor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


if (StringUtils.isNotEmpty(exceptionText)) {
throw new MissingInformationMailException(exceptionText.toString());
public void sendMail(final Mail mail) throws RuntimeException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Valid Mail mail

throw new MissingInformationMailException(exceptionText.toString());
public void sendMail(final Mail mail) throws RuntimeException {
// validation
final Validator validator = this.validatorFactory.getValidator();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kannst du weglassen, wenn du @Validated und @Valid machst.

@@ -140,9 +149,10 @@
"value": "",
"description": "Create an array with json.array('','') (not yet implemented)",
"binding": {
"type": "camunda:in",
"type": "camunda:inputParameter",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warum inputParameter? ist doch für eine CallActivity oder?

@@ -6,7 +6,7 @@
<parent>
<artifactId>digiwf-email-integration-parent</artifactId>
<groupId>io.muenchendigital.digiwf</groupId>
<version>0.0.2</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.1.0

@lmoesle
Copy link
Contributor Author

lmoesle commented Oct 17, 2022

Super Job +1

Wollen wir ein Issue machen, um es ins monorepo zu migrieren?

@dominikhorn93 Danke für die Review 😃

Eine Issue bzw. Epic habe ich schon erstellt. Ich bereite das für das Planning noch ein wenig auf.
https://app.zenhub.com/workspaces/digiwf-621f70bf50ea1100120b7e93/issues/it-at-m/digiwf-project/356

logging.level.io.muenchendigital=info
logging.level.org.springframework=info
spring.cloud.stream.kafka.binder.brokers=localhost:9092
#spring.cloud.stream.kafka.binder.brokers=dwf-cluster-kafka-tls-bootstrap-lhmeventbus.apps.capk.muenchen.de:443
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is lhm specific and should be removed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other lines within this properties files are specific too

@@ -17,35 +14,30 @@
import javax.mail.Message;
import javax.mail.internet.InternetAddress;
import javax.mail.util.ByteArrayDataSource;
import javax.validation.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wild card imports should be avoided

Comment on lines 1 to 25
logging.level.io.muenchendigital=info
logging.level.org.springframework=info
spring.cloud.stream.kafka.binder.brokers=localhost:9092
#spring.cloud.stream.kafka.binder.brokers=dwf-cluster-kafka-tls-bootstrap-lhmeventbus.apps.capk.muenchen.de:443
io.muenchendigital.digiwf.engineTopic=dwf-digiwf-engine-local-01
io.muenchendigital.digiwf.email.topic=dwf-email-local-01
io.muenchendigital.digiwf.email.group="dwf-email-local-01"
# default email settings for mailhog
spring.mail.host=localhost
spring.mail.port=1025
spring.mail.username=itm.digitalwf-test@muenchen.de
spring.mail.password=test
spring.mail.properties.mail.debug=false
spring.mail.properties.mail.tls=false
spring.mail.properties.mail.transport.protocol=smtp
spring.mail.properties.mail.smtp.host=localhost
spring.mail.properties.mail.smtp.port=1025
spring.mail.properties.mail.smtp.connectiontimeout=1000000
spring.mail.properties.mail.smtp.timeout=1000000
spring.mail.properties.mail.smtp.auth=false
spring.mail.properties.mail.smtp.ssl.trust="*"
spring.mail.properties.mail.smtp.ssl.checkserveridentity=false
spring.mail.properties.mail.smtp.socketFactory.fallback=true
spring.mail.properties.mail.smtp.starttls.enable=false
io.muenchendigital.digiwf.mail.fromAddress=itm.digitalwf-test@muenchen.de
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove lhm specific prop values

@@ -126,8 +134,9 @@
"type": "String",
"value": "",
"binding": {
"type": "camunda:in",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Da gilt doch für alle Inputs oder?
Verstehe nicht warum die auf inputParameter sind.
Dadurch landen die ja nicht im StreamingTemplate oder verstehe ich das gerade falsch?

dominikhorn93
dominikhorn93 previously approved these changes Oct 18, 2022
@dominikhorn93 dominikhorn93 dismissed their stale review October 18, 2022 16:29

Noch eine Frage zum Element Template

@lmoesle lmoesle merged commit 1c9a2b4 into dev Oct 19, 2022
@lmoesle lmoesle deleted the feat/projectspecific-s3 branch October 19, 2022 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants