Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 mask surveys and analytics tabs #Clm 338 #880

Merged
merged 26 commits into from
Dec 5, 2023

Conversation

JAPHETHNYARANGA
Copy link
Contributor

@JAPHETHNYARANGA JAPHETHNYARANGA commented Nov 23, 2023

Description

In this issue , i have implements a flags feature, where items in the sidenav can be added or deleted on the fly.

Fixes # (issue) - Example: Fixes #10, #20 NOTE: GitHub issue numbers should be prefixed with # to aid with issue tracking.

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshot (optional)

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Copy link

github-actions bot commented Nov 23, 2023

Visit the preview URL for this PR (updated for commit 4951120):

https://elewa-clm-test--pr880-clm-338-mask-surveys-h3wczdpg.web.app

(expires Tue, 12 Dec 2023 11:48:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ae299225ffe24890ed0d4bb1bc6faaa55efdc656

Copy link
Contributor

@LemmyMwaura LemmyMwaura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good job so far.

A few updates left. Also, add a route guard for the feature flags as I can manually change the routes to features that are marked as false.

@LemmyMwaura LemmyMwaura merged commit 31e35f5 into develop Dec 5, 2023
2 checks passed
@LemmyMwaura LemmyMwaura deleted the CLM-338-Mask-Surveys-and-Analytics-tabs branch December 22, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🤖 🎨 [Application setup] Add PWA capabilities & favicon to the application
2 participants