refactor: remove the custom ErrDBUniqueConstraint error #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
bfabio
force-pushed
the
gorm-err-unique-violation
branch
from
c9e16ef
to
a54001f
Compare
bfabio
force-pushed
the
gorm-err-unique-violation
branch
2 times, most recently
from
b7496f8
to
d251666
Compare
Remove common.ErrDBUniqueConstraint, which was used as a workaround for the lack of abstraction in gorm. With the update in go-gorm/gorm#6004 we can now fully use gorm for db related errors (fe. gorm.ErrDuplicatedKey).
bfabio
force-pushed
the
gorm-err-unique-violation
branch
from
d251666
to
0ad6a82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove common.ErrDBUniqueConstraint, which was used as a workaround for the lack of abstraction in gorm.
With the update in go-gorm/gorm#6004 we can now fully use gorm for db related errors (fe. gorm.ErrDuplicatedKey).