Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add search parameters in GET /v1/logs #237

Merged
merged 18 commits into from
Apr 9, 2024
Merged

feat: add search parameters in GET /v1/logs #237

merged 18 commits into from
Apr 9, 2024

Conversation

nesangcode
Copy link
Contributor

User can find related message field in the log by including search parameters in GET /v1/logs

Example:

GET /v1/logs/?search=logmessage

closes #236

Copy link
Member

@bfabio bfabio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you please also add the new parameter to the OpenAPI spec?

main_test.go Outdated Show resolved Hide resolved
@nesangcode
Copy link
Contributor Author

Thanks!

Can you please also add the new parameter to the OpenAPI spec?

Sure.

@nesangcode
Copy link
Contributor Author

Can we improve this further by making the search result case insensitive?

@bfabio
Copy link
Member

bfabio commented Apr 8, 2024

Can we improve this further by making the search result case insensitive?

Yes, good idea

@nesangcode
Copy link
Contributor Author

Why spectral didn't pass when it encounters debug word?

@bfabio
Copy link
Member

bfabio commented Apr 9, 2024

Why spectral didn't pass when it encounters debug word?

I'm not sure, maybe it matched some rule.

.gitignore Outdated Show resolved Hide resolved
developers-italia.oas.yaml Outdated Show resolved Hide resolved
developers-italia.oas.yaml Outdated Show resolved Hide resolved
test/testdata/fixtures/logs.yml Outdated Show resolved Hide resolved
test/testdata/fixtures/logs.yml Outdated Show resolved Hide resolved
test/testdata/fixtures/logs.yml Outdated Show resolved Hide resolved
test/testdata/fixtures/logs.yml Outdated Show resolved Hide resolved
test/testdata/fixtures/logs.yml Outdated Show resolved Hide resolved
main_test.go Outdated Show resolved Hide resolved
Copy link
Member

@bfabio bfabio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k124k3n thank you for your work!

@bfabio bfabio merged commit 0b39748 into italia:main Apr 9, 2024
6 checks passed
@nesangcode
Copy link
Contributor Author

Thanks for guiding me resolving this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add search parameters to GET /logs
2 participants