Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change test IdP settings #77

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Conversation

brunato
Copy link
Collaborator

@brunato brunato commented Jul 13, 2021

This PR updates settings of test IdPs, adding also a couple of configuration settings for SPID validator, useful when the onboarding procedure has to be done. Some settings ere renamed in order to match the current meaning of the configuration entry. When a test IdP is activated its name is added to the rendered spid_button.html template, so one doesn't need to provide an override to remove test IdPs from SPID button, but simply change the settings.

Changes:

  • Add SPID_VALIDATOR_IDP_ACTIVE and SPID_VALIDATOR_METADATA_URL
  • SPID_SAML_CHECK_DEMO_REMOTE_METADATA_ACTIVE -> SPID_DEMO_IDP_ACTIVE
  • SPID_SAML_CHECK_DEMO_METADATA_URL -> SPID_DEMO_METADATA_URL
  • SPID_SAML_CHECK_REMOTE_METADATA_ACTIVE -> SPID_SAML_CHECK_IDP_ACTIVE
    (also checking the old name as fallback)
  • New template tags for checking if add test IdPs to SPID button

Note: it could be have a sense to add SPID validator and SPID Demo metadata to package or otherwise to update the update_idps.py script to download also their metadata.

  - Add SPID_VALIDATOR_IDP_ACTIVE and SPID_VALIDATOR_METADATA_URL
  - SPID_SAML_CHECK_DEMO_REMOTE_METADATA_ACTIVE -> SPID_DEMO_IDP_ACTIVE
  - SPID_SAML_CHECK_DEMO_METADATA_URL -> SPID_DEMO_METADATA_URL
  - SPID_SAML_CHECK_REMOTE_METADATA_ACTIVE -> SPID_SAML_CHECK_IDP_ACTIVE
    (also checking the old name as fallback)
  - New template tags for checking if add test IdPs to SPID button
@brunato brunato requested a review from peppelinux July 13, 2021 15:44
Copy link
Member

@peppelinux peppelinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thank you

@brunato brunato merged commit 933290b into italia:dev Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants