feat: CIE metadata endpoint and attributes #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it would be better to have also the button "Entra con CIE" in the discovery page, insn't so @brunato? |
peppelinux
commented
Jul 18, 2021
| @@ -129,10 +129,6 @@ def test_get_config(self): | |||
| saml_config = get_config() | |||
| self.assertIsNone(saml_config.entityid) | |||
|
|
|||
| request = self.factory.get("") | |||
There was a problem hiding this comment.
@brunato is there some particular need to have this kind of check? It looks to me quite pedant, please tell me how you put it there, probably is useful for something.
as you can see I also changed this behaviour to our default config_loader,
tell me more when possibile, thx
brunato
approved these changes
Jul 19, 2021
peppelinux
pushed a commit
that referenced
this pull request
Jul 19, 2021
* chore: spid metadata as django class view * chore: README setup additional informations and tips * - fix: spid-django example project now works also with django 2.2 - chore: removed spid-testenv2 from README - feat: added 'allow_unsolicited` as customizable parameter in SAML_CONF SETTING * feat: CIE metadata endpoint and attributes (#80) * feat: CIE metadata endpoint and attributes * fix: removed useless test regarding the metadata web path * v1.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here a way to handle a CIE SP integration in the existing SPID SP.