Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: authnContext to string #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: authnContext to string #33

wants to merge 2 commits into from

Conversation

Datalux
Copy link

@Datalux Datalux commented Mar 9, 2021

Fix per #32

Versione di TypeScript: 4.2.2

@bfabio
Copy link
Member

bfabio commented Mar 20, 2021

@Datalux this doesn't look right to me, why are we removing the type? And isn't entityID already a string?

@peppelinux
Copy link
Member

@bfabio we still have those spurious error messages due to #32

This pr fixed It but we Need to keep an Eye on the cause of these undefined values, if we converte them to a string (even if "") It doesn't throw that warning/error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfabio bfabio Awaiting requested review from bfabio bfabio is a code owner

@sebbalex sebbalex Awaiting requested review from sebbalex

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Datalux @bfabio @peppelinux