Autoxhelm create ArgoCD application #1355

Alan-Cha · 2022-10-14T13:52:01Z

No description provided.

autox/informer.go

sriumcp

Idempotence of autox + a few minor naming changes, and visibility changes (for kubeclient).

autox/application.tpl

sriumcp · 2022-10-14T19:05:47Z

autox/application.tpl

+    targetRevision: {{ .chart.version }}
+  syncPolicy:
+    automated:
+      prune: true


Document what prune and selfHeal mean.

prune:

https://argo-cd.readthedocs.io/en/stable/user-guide/auto_sync/#automatic-pruning

By default (and as a safety mechanism), automated sync will not delete resources when Argo CD detects the resource is no longer defined in Git. To prune the resources, a manual sync can always be performed (with pruning checked). Pruning can also be enabled to happen automatically as part of the automated sync by... setting this option.

@sriumcp @kalantar If this is related to git, then should we get rid of it?

selfHeal:

https://argo-cd.readthedocs.io/en/stable/user-guide/auto_sync/#automatic-self-healing

By default, changes that are made to the live cluster will not trigger automated sync. To enable automatic sync when the live cluster's state deviates from the state defined in Git... set this option.

We want the changes to trigger a sync but I'm not sure what how Argo CD's Git usage means in relationship with what we are doing.

autox/config.go

autox/informer.go

sriumcp · 2022-10-17T16:04:18Z

autox/informer.go

 )

 type chartAction int64

 const (
 	releaseAction chartAction = 0
 	deleteAction  chartAction = 1
+
+	applicationTemplateFilePath string = "application.tpl"


Decide between embed and using an arguCD typed application struct.

sriumcp

ignore approve!

autox/application.tpl

autox/config.go

autox/watcher.go

autox/k8sclient.go

autox/watcher.go

autox/informer.go

sriumcp

Please see initial comments. More comments to follow.

autox/application.tpl

autox/config.go

sriumcp

Please see requested changes.

autox/informer.go

autox/watcher.go

autox/informer.go

sriumcp

Please see comments on informer.

autox/application.tpl

autox/informer.go

Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com> Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

sriumcp

Please see a small change requested for delete logic.

autox/informer.go

Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

autox/informer.go

Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

sriumcp

Minor comment.

autox/watcher_test.go

Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

Update workflows Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

autox/application.tpl

autox/config.go

autox/watcher.go

base/util.go

autox/informer.go

sriumcp · 2022-12-02T16:58:06Z

autox/informer_test.go

+
+	// autoX handler will call on applyHelmRelease and deleteHelmRelease
+	applyHelmReleaseInvocations := 0
+	applyHelmRelease = func(releaseName string, specGroupName string, releaseSpec releaseSpec, namespace string, additionalValues map[string]string) error {


Query the cluster. Do not mock applyHelmRelease and delete. Instead query the cluster and make sure it looks right (e.g., no objects after delete; appropriate application objects after apply).

Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

Alan-Cha · 2023-01-11T19:26:50Z

See #1387

Alan-Cha force-pushed the autoxhelm4 branch 4 times, most recently from 54ed544 to 5b82f23 Compare October 14, 2022 15:08

Alan-Cha marked this pull request as ready for review October 14, 2022 18:29

Alan-Cha commented Oct 14, 2022

View reviewed changes

autox/informer.go Outdated Show resolved Hide resolved

Alan-Cha commented Oct 14, 2022

View reviewed changes

autox/informer.go Show resolved Hide resolved

sriumcp mentioned this pull request Oct 17, 2022

AutoX helm actions #1340

Closed

sriumcp requested changes Oct 17, 2022

View reviewed changes

sriumcp self-requested a review October 17, 2022 16:03

sriumcp approved these changes Oct 17, 2022

View reviewed changes

sriumcp self-requested a review October 17, 2022 16:04

sriumcp requested changes Oct 17, 2022

View reviewed changes

Alan-Cha force-pushed the autoxhelm4 branch 5 times, most recently from dc45464 to 0c00b4e Compare November 3, 2022 20:58

kalantar requested changes Nov 4, 2022

View reviewed changes

This was referenced Nov 8, 2022

Add version constraint to autoX release spec #1367

Closed

AutoX release spec access control #1368

Closed

sriumcp requested changes Nov 9, 2022

View reviewed changes

autox/application.tpl Outdated Show resolved Hide resolved

autox/config.go Outdated Show resolved Hide resolved

sriumcp requested changes Nov 14, 2022

View reviewed changes

autox/informer.go Outdated Show resolved Hide resolved

autox/watcher.go Show resolved Hide resolved

autox/informer.go Outdated Show resolved Hide resolved

kalantar requested changes Nov 18, 2022

View reviewed changes

autox/informer.go Outdated Show resolved Hide resolved

autox/informer.go Outdated Show resolved Hide resolved

sriumcp requested changes Nov 18, 2022

View reviewed changes

autox/application.tpl Outdated Show resolved Hide resolved

autox/informer.go Outdated Show resolved Hide resolved

Alan-Cha force-pushed the autoxhelm4 branch 2 times, most recently from be66969 to 29072d0 Compare November 22, 2022 05:20

sriumcp and others added 3 commits November 22, 2022 00:24

autox helm actions

ada1609

Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com> Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

autox outline

84fbe2c

Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com> Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

Fix tests

1d9d4fa

Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

Alan-Cha force-pushed the autoxhelm4 branch from f089f21 to a8ad01e Compare November 22, 2022 05:33

Alan-Cha requested review from kalantar and sriumcp November 22, 2022 21:26

sriumcp requested changes Nov 22, 2022

View reviewed changes

autox/informer.go Show resolved Hide resolved

autox/informer.go Outdated Show resolved Hide resolved

autox/informer.go Outdated Show resolved Hide resolved

Alan-Cha added 3 commits November 28, 2022 10:06

Address comments

85e74ca

Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

Tweaks

b8ef886

Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

Remove prunedLabels

1386524

Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

sriumcp requested changes Nov 28, 2022

View reviewed changes

autox/informer.go Outdated Show resolved Hide resolved

autox/informer.go Outdated Show resolved Hide resolved

Alan-Cha added 4 commits November 28, 2022 13:57

Add additionalValues

a24fc96

Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

Add additionalValues in template

a0c42d3

Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

Add comments

b6fd352

Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

Fix typo

8dc8f4d

Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

sriumcp requested changes Nov 28, 2022

View reviewed changes

autox/watcher_test.go Outdated Show resolved Hide resolved

More typos

b52d4b0

Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

sriumcp self-requested a review November 29, 2022 18:32

Alan-Cha added 3 commits November 30, 2022 14:29

Apply instead of create

232987d

Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

Update to go 1.19

1cf4065

Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

Fix iter8-tools#1373

287782f

Update workflows Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

Alan-Cha force-pushed the autoxhelm4 branch from a35fd2c to 287782f Compare November 30, 2022 21:10

Remove static-check test

9ea003f

Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

sriumcp requested changes Dec 2, 2022

View reviewed changes

Alan-Cha added 5 commits December 5, 2022 13:57

Respond to comments

99fcde4

Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

Revert name change

9ee2363

Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

Add spacing to logging

eecfbb5

Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

Experiment running

0b83c41

Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

Improve logging

1a80ca0

Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

Alan-Cha mentioned this pull request Jan 11, 2023

AutoX feature #1387

Merged

Alan-Cha closed this Jan 11, 2023

Alan-Cha deleted the autoxhelm4 branch May 10, 2023 12:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Autoxhelm create ArgoCD application #1355

Autoxhelm create ArgoCD application #1355

Alan-Cha commented Oct 14, 2022

sriumcp left a comment

sriumcp Oct 14, 2022

Alan-Cha Nov 22, 2022

sriumcp Oct 17, 2022

sriumcp left a comment

sriumcp left a comment

sriumcp left a comment

sriumcp left a comment

sriumcp left a comment

sriumcp left a comment

sriumcp Dec 2, 2022

Alan-Cha commented Jan 11, 2023

Autoxhelm create ArgoCD application #1355

Autoxhelm create ArgoCD application #1355

Conversation

Alan-Cha commented Oct 14, 2022

sriumcp left a comment

Choose a reason for hiding this comment

sriumcp Oct 14, 2022

Choose a reason for hiding this comment

Alan-Cha Nov 22, 2022

Choose a reason for hiding this comment

sriumcp Oct 17, 2022

Choose a reason for hiding this comment

sriumcp left a comment

Choose a reason for hiding this comment

sriumcp left a comment

Choose a reason for hiding this comment

sriumcp left a comment

Choose a reason for hiding this comment

sriumcp left a comment

Choose a reason for hiding this comment

sriumcp left a comment

Choose a reason for hiding this comment

sriumcp left a comment

Choose a reason for hiding this comment

sriumcp Dec 2, 2022

Choose a reason for hiding this comment

Alan-Cha commented Jan 11, 2023