Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor requirements #73

Merged
merged 3 commits into from
Apr 16, 2019
Merged

Refactor requirements #73

merged 3 commits into from
Apr 16, 2019

Conversation

petrbel
Copy link
Member

@petrbel petrbel commented Apr 16, 2019

Take a look at circleci and setup.py from shepherd

@petrbel petrbel requested a review from FloopCZ April 16, 2019 09:32
FloopCZ
FloopCZ approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@FloopCZ FloopCZ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, but the docs needs to be updated in section Developer Installation and the same for CONTRIBUTING.md.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2032

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 88.796%
Totals Coverage Status
Change from base Build 2018: 0.003%
Covered Lines: 3947
Relevant Lines: 4445
💛 - Coveralls

@petrbel petrbel merged commit a9ee672 into dev Apr 16, 2019
@petrbel petrbel deleted the reqs-refactor branch April 16, 2019 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloopCZ FloopCZ FloopCZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petrbel @coveralls @FloopCZ