Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a custom chunksize to the GetContentFile method. #50

Merged
merged 2 commits into from
Aug 1, 2020
Merged

Added a custom chunksize to the GetContentFile method. #50

merged 2 commits into from
Aug 1, 2020

Conversation

TanukiAI
Copy link
Contributor

@TanukiAI TanukiAI commented Aug 1, 2020

Added the optional custom chunksize to the GetContentFile method.

Worked fine in my tests (I just forgot to init colorama in my callback, so it printed ?[2A instead of printing the progressbar in the same line)

@TanukiAI TanukiAI mentioned this pull request Aug 1, 2020
Closed
@shcheklein
Copy link
Member

@TA40 this is looks as a good start! CI fails due to formatting - you'd need to setup an environment similar to this - https://dvc.org/doc/user-guide/contributing/core#development-environment (especially pre-commit install part) and amend + force push the commit.

shcheklein
shcheklein approved these changes Aug 1, 2020
View reviewed changes
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging to run tests (since tests rely on secrets we can't run them from a fork).

@shcheklein shcheklein merged commit d0134ce into iterative:master Aug 1, 2020
@TanukiAI
Copy link
Contributor Author

TanukiAI commented Aug 1, 2020

Was really worried because the tests failed, because this was my first time making a pull request.
Good to know everything's alright.

@shcheklein
Copy link
Member

@TA40 ah, no worries. Everything looks good and tests on master don't fail. I gonna release a new version today.

@shcheklein
Copy link
Member

@TA40 1.6.0 is released. Please give it a try and thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shcheklein shcheklein shcheklein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TanukiAI @shcheklein