New container entry point could be overriding cml pr command with shell homonym

[0x2b3bfa0]

The new smart entry point introduced with #703 could be overriding cml pr the pr(1p) system executable. As per #703 (comment), we should probably consider aliasing only sh fb82963 or using CMD instead.

cml/Dockerfile

Line 108 in 4f7a5d9

ENTRYPOINT ["/bin/bash", "-c", "which -- \"$0\" &>/dev/null && exec \"$0\" \"$@\" || exec cml \"$0\" \"$@\""]

[casperdcl]

I don't see any realistic scenario where anyone would do docker run cml pr expecting the behaviour of docker run cml /bin/pr

[DavidGOrtega]

I think that ability is misleading, cml does not support that outside the docker image

[0x2b3bfa0]

I still see the value of adding an exception for sh (and nothing else) so our images work on GitLab CI/CD. Allowing every command with allow/deny lists doesn't seem especially clean, but is the only way of allowing other commands like nvidia-smi as you wanted.