Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow native GPU types #1049

Merged
merged 3 commits into from
Jun 7, 2022
Merged

Allow native GPU types #1049

merged 3 commits into from
Jun 7, 2022

Conversation

0x2b3bfa0
Copy link
Member

Closes #1048

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal June 6, 2022 07:32 Inactive
@0x2b3bfa0 0x2b3bfa0 requested a review from a team June 6, 2022 07:32
@0x2b3bfa0 0x2b3bfa0 self-assigned this Jun 6, 2022
@0x2b3bfa0 0x2b3bfa0 added bug Something isn't working ui/ux User interface/experience labels Jun 6, 2022
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal June 6, 2022 07:35 Inactive
@0x2b3bfa0 0x2b3bfa0 marked this pull request as ready for review June 6, 2022 07:35
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Jun 6, 2022
Closed
casperdcl
casperdcl reviewed Jun 6, 2022
View reviewed changes
bin/cml/runner.js Outdated Show resolved Hide resolved
casperdcl
casperdcl reviewed Jun 6, 2022
View reviewed changes
Copy link
Contributor

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small suggestion

dacbd added a commit to iterative/cml-playground that referenced this pull request Jun 6, 2022
@dacbd
https://github.com/iterative/cml/pull/1049
35e74e3
dacbd
dacbd previously approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@dacbd dacbd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the user example on my personal account 🙃 and got a nice: Quota 'GPUS_ALL_REGIONS' exceeded. Limit: 0.0 globally. So I assume this work just fine 🙈 👍

ref:

      - name: Create Runner
        env:
          REPO_TOKEN: ${{ secrets.REPO_TOKEN }}
        run: |
          cml runner \
            --single=true \
            --labels=LABEL \
            --cloud=gcp \
            --cloud-region=us-west \
            --cloud-type=n1-highmem-2 \
            --cloud-spot=false \
            --cloud-gpu=nvidia-tesla-t4 \
            --cloud-hdd-size=50

Good with me pending description wording resolution?

@0x2b3bfa0 0x2b3bfa0 enabled auto-merge (squash) June 6, 2022 20:15
@0x2b3bfa0 @casperdcl
Apply code review suggestions
e61185a 
Co-authored-by: Casper da Costa-Luis <casper.dcl@physics.org>
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal June 6, 2022 20:16 Inactive
@0x2b3bfa0 0x2b3bfa0 requested review from casperdcl and dacbd June 6, 2022 20:16
dacbd
dacbd previously approved these changes Jun 6, 2022
View reviewed changes
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal June 7, 2022 10:54 Inactive
@0x2b3bfa0 0x2b3bfa0 requested a review from dacbd June 7, 2022 10:54
@0x2b3bfa0 0x2b3bfa0 merged commit f341321 into master Jun 7, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the native-gpu branch June 7, 2022 14:53
@casperdcl
Copy link
Contributor

casperdcl commented Jun 9, 2022 •
edited
Loading

docs follow-up: iterative/cml.dev#251

@casperdcl casperdcl mentioned this pull request Jun 14, 2022
Merged
@dacbd dacbd mentioned this pull request Sep 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dacbd dacbd dacbd approved these changes

@casperdcl casperdcl Awaiting requested review from casperdcl

Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
bug Something isn't working ui/ux User interface/experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to use t4 GPU from GCP
3 participants
@0x2b3bfa0 @casperdcl @dacbd