Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GitHub Container Registry #500

Merged
merged 1 commit into from
May 10, 2021
Merged

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented May 9, 2021

Untested proposal to fix #267, intended for review after and if we choose to support this option. May require enabling the container registry on the organization.

@0x2b3bfa0 0x2b3bfa0 added the cml-image Subcommand label May 9, 2021
@0x2b3bfa0 0x2b3bfa0 self-assigned this May 9, 2021
@0x2b3bfa0 0x2b3bfa0 requested a review from casperdcl May 9, 2021 21:14
Undo involuntary alphabetical relocation

Standardize secret source for grcr.io login

Fix default registry domain

Prefix Docker Hub repositories
@casperdcl
Copy link
Contributor

May require enabling the container registry on the organi[s]ation.

done

Copy link
Contributor

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any harm in adding this as an option. We can always disable/remove later if there are no users.

@0x2b3bfa0 0x2b3bfa0 marked this pull request as ready for review May 10, 2021 08:35
@0x2b3bfa0 0x2b3bfa0 linked an issue May 10, 2021 that may be closed by this pull request
@0x2b3bfa0 0x2b3bfa0 merged commit deb5ec2 into devel May 10, 2021
@0x2b3bfa0 0x2b3bfa0 deleted the add-ghcr-registry branch May 10, 2021 09:06
@casperdcl casperdcl mentioned this pull request May 10, 2021
2 tasks
casperdcl added a commit that referenced this pull request May 10, 2021
including #500/#267 `ghcr.io`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cml-image Subcommand
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate GitHub Docker registry
2 participants