Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imgs: (re)move & update #555

Merged
merged 2 commits into from
May 27, 2021
Merged

imgs: (re)move & update #555

merged 2 commits into from
May 27, 2021

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl commented May 21, 2021

@casperdcl casperdcl added documentation Markdown files technical-debt Refactoring, linting & tidying labels May 21, 2021
@casperdcl casperdcl self-assigned this May 21, 2021
@casperdcl casperdcl temporarily deployed to test-internal May 21, 2021 13:24 Inactive
@casperdcl casperdcl temporarily deployed to test-internal May 21, 2021 13:56 Inactive
@casperdcl casperdcl temporarily deployed to test-internal May 21, 2021 14:05 Inactive
@casperdcl casperdcl force-pushed the lintCamel branch 2 times, most recently from 50b3fb8 to f7f945f Compare May 21, 2021 15:44
@casperdcl
Copy link
Contributor Author

casperdcl commented May 21, 2021

@shcheklein / @arcticbear are you fine with the banner?

I lifted the dark SVG version, added a 0.5pt white border to the text, and exported as a 1400px width PNG with alpha. This means it looks decent even with a dark background (i.e. GH dark).

Also not sure about why the other images have such wide alpha padding.

Btw can you see the line artefacts in the logo above? Looks like the SVG paths don't quite align.

bin/cml-pr.js Outdated Show resolved Hide resolved
Base automatically changed from lintCamel to devel May 27, 2021 15:28
@casperdcl casperdcl temporarily deployed to test-internal May 27, 2021 15:41 Inactive
@casperdcl casperdcl marked this pull request as ready for review May 27, 2021 16:00
@casperdcl casperdcl merged commit cb10849 into devel May 27, 2021
@casperdcl casperdcl deleted the imgs branch May 27, 2021 16:01
@casperdcl casperdcl mentioned this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Markdown files technical-debt Refactoring, linting & tidying
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants