Runners not unregistering due to camelCase

[DavidGOrtega]

GH api uses snake_case 🐍 due to this GH are not unregistering successfully anymore

Fixed in #583 however it might take longer and this is important.

[0x2b3bfa0]

What if we delay the conversion to snake_case until the invocation of the GitHub API? Anyhow, it might be a bit more verbose, so I don't have a strong preference over any of the methods.

[0x2b3bfa0]

Looks good to me!

[DavidGOrtega]

What if we delay the conversion to snake_case until the invocation of the GitHub API? Anyhow, it might be a bit more verbose, so I don't have a strong preference over any of the methods.

Its ugly, normally in modern js you destructure looking to match the needed member later on. In this case Im going to reuse id straight to avoid lint but in the future we should destructure snake_case and add a lint ignore rule

[casperdcl]

I also prefer the "ugly but correct/consistent" way suggested by @0x2b3bfa0 and used in the rest of the codebase (and my Python bias avoids variables called id) but whatever

[DavidGOrtega]

In this case was done just because is easy to read. If it were 20 lines I would not have done it either. But here is totally fine because you use it afterwards assignment

Indeed just after

const { id } = await this.runnerByName({ name });

So you understand that the id is the runner's id

[DavidGOrtega]

unless your memory is worse than mine 👴