Fix cml-pr reference handling for pull requests #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x2b3bfa0
commented
Jun 30, 2021
0x2b3bfa0
force-pushed
the
fix-pull-request-references
branch
from
408a306
to
26b90b5
Compare
0x2b3bfa0
force-pushed
the
fix-pull-request-references
branch
from
26b90b5
to
961aa4c
Compare
Avoids `fatal: reference is not a tree: {SHA}` where `{SHA}` is the commit.
0x2b3bfa0
force-pushed
the
fix-pull-request-references
branch
from
3384855
to
90cd1c8
Compare
DavidGOrtega
suggested changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workflows triggered with the
pull_requestGitHub Actions event are going to havegithub.refset to one of the pull references that GitHub creates for pull requests. We haven't noticed until now because all the tests were made using thepushevent.We only consider
headsandtagsreferences and remove the first path components with a regular expression, and it works pretty well for these two kinds of references, but fails for thepullones:cml/src/drivers/github.js
Line 24 in 6c451d9
The most elegant solution I can think of would using a short-circuit evaluation fallback to
GITHUB_HEAD_REF || GITHUB_REFso it doesn't have to deal with pull references at all.