Require runners to be online when honoring --reuse #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x2b3bfa0
force-pushed
the
detect-runner-status
branch
from
a0ac3af
to
679eccd
Compare
0x2b3bfa0
force-pushed
the
detect-runner-status
branch
from
679eccd
to
44eefbd
Compare
Apply eslint locally Restyled by prettier
0x2b3bfa0
force-pushed
the
detect-runner-status
branch
from
88ecdcf
to
4eed1a7
Compare
DavidGOrtega
reviewed
Jul 1, 2021
0x2b3bfa0
force-pushed
the
detect-runner-status
branch
from
be7ee9b
to
57b4bdf
Compare
0x2b3bfa0
commented
Jul 1, 2021
src/drivers/gitlab.js
Outdated
| return await Promise.all( | ||
| runners.map(async ({ id, name, description, active, online }) => ({ | ||
| id, | ||
| name: name || description, |
There was a problem hiding this comment.
Suggested change
| name: name || description, | |
| name: description, |
The name property is always null because POST /runners doesn't accept it. We're using description instead of name to store a custom string.
There was a problem hiding this comment.
I would say this is true in the meantime GL fixes this bug on their side. The name should be changed and not the description so I would say is ok for now
It was breaking the tests 🤷🏼♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--reuseoption should not consider offline runners as reusable.