Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test dispatch & basic OS commands #734

Merged
merged 3 commits into from
Sep 22, 2021
Merged

test dispatch & basic OS commands #734

merged 3 commits into from
Sep 22, 2021

Conversation

casperdcl
Copy link
Contributor

we don't test on pushes so this'll be useful to test e.g. #733

@casperdcl casperdcl self-assigned this Sep 22, 2021
@casperdcl casperdcl temporarily deployed to internal September 22, 2021 12:27 Inactive
@casperdcl casperdcl added the testing Unit tests & debugging label Sep 22, 2021
@0x2b3bfa0
Copy link
Member

In the case of #733, it wouldn't matter if we test on push or just on pull_request (synchronization)... we can manually workflow_dispatch any branch from the dropdown as you have in mind, or simply update the pull request like in 6b8403c and let the tests run again.

0x2b3bfa0
0x2b3bfa0 approved these changes Sep 22, 2021
View reviewed changes
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you feel it necessary after #734 (comment), :shipit:

@casperdcl
Copy link
Contributor Author

unfortunately still passes. Needs to actually install & run some commands...

@casperdcl casperdcl temporarily deployed to internal September 22, 2021 12:35 Inactive
@casperdcl
Copy link
Contributor Author

wonder if --version will be good enough. Trying to avoid having to do cml publish --md :)

@casperdcl casperdcl changed the title test dispatch test dispatch & commands Sep 22, 2021
@casperdcl casperdcl temporarily deployed to internal September 22, 2021 12:45 Inactive
@casperdcl
Copy link
Contributor Author

-.- rate limiting

@casperdcl casperdcl temporarily deployed to internal September 22, 2021 12:54 Inactive
@casperdcl casperdcl changed the title test dispatch & commands test dispatch & basic OS commands Sep 22, 2021
@casperdcl casperdcl merged commit 7d664ae into master Sep 22, 2021
@casperdcl casperdcl deleted the workflow_dispatch branch September 22, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x2b3bfa0 0x2b3bfa0 0x2b3bfa0 approved these changes

Assignees

@casperdcl casperdcl

Labels
testing Unit tests & debugging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casperdcl @0x2b3bfa0