Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine #974 safe directory code #986

Merged
merged 2 commits into from
Apr 23, 2022
Merged

Refine #974 safe directory code #986

merged 2 commits into from
Apr 23, 2022

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Apr 22, 2022 •
edited
Loading

While #974 (comment) was left unresolved because of the priority of the bug, it's an eyesore and should be improved.

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal April 22, 2022 19:32 Inactive
@0x2b3bfa0 0x2b3bfa0 self-assigned this Apr 22, 2022
@0x2b3bfa0 0x2b3bfa0 added the technical-debt Refactoring, linting & tidying label Apr 22, 2022
@0x2b3bfa0 0x2b3bfa0 marked this pull request as ready for review April 23, 2022 08:25
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal April 23, 2022 08:37 Inactive
@casperdcl casperdcl merged commit 352fba4 into master Apr 23, 2022
@casperdcl casperdcl deleted the refine-974 branch April 23, 2022 09:52
@0x2b3bfa0 0x2b3bfa0 linked an issue Apr 23, 2022 that may be closed by this pull request
Git safe.directory — next steps #984
Closed
2 tasks
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Apr 25, 2022
Merged
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Oct 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperdcl casperdcl casperdcl approved these changes

Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
technical-debt Refactoring, linting & tidying
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Git safe.directory — next steps
2 participants
@0x2b3bfa0 @casperdcl