Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get Started: Model Management #4883

Merged
merged 101 commits into from
Nov 16, 2023
Merged

Get Started: Model Management #4883

merged 101 commits into from
Nov 16, 2023

Conversation

tibor-mach
Copy link
Contributor

No description provided.

@restyled-io restyled-io bot mentioned this pull request Sep 27, 2023
Merged
@tibor-mach tibor-mach marked this pull request as ready for review September 27, 2023 09:59
@tibor-mach tibor-mach requested a review from a team as a code owner September 27, 2023 09:59
@restyled-io @restyled-commits
Restyled by prettier (#4884)
76f7331 
Co-authored-by: Restyled.io <commits@restyled.io>
@tibor-mach tibor-mach removed request for dberenbaum and a team September 27, 2023 10:01
@tibor-mach tibor-mach marked this pull request as draft September 27, 2023 10:03
@shcheklein shcheklein temporarily deployed to dvc-org-getting-started-znzk6m September 27, 2023 10:03 Inactive
@tibor-mach tibor-mach changed the title Model management Getting Started docs Get Started: Model Management Sep 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023 •
edited
Loading

Link Check Report

There were no links to check!

@shcheklein shcheklein temporarily deployed to dvc-org-getting-started-qh25mj September 27, 2023 14:35 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-getting-started-qh25mj September 27, 2023 16:33 Inactive
@restyled-io restyled-io bot mentioned this pull request Sep 27, 2023
Merged
@restyled-io @restyled-commits
Restyled by prettier (#4886)
b55bbbb 
Co-authored-by: Restyled.io <commits@restyled.io>
@shcheklein shcheklein temporarily deployed to dvc-org-getting-started-qh25mj September 27, 2023 16:42 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-getting-started-qh25mj September 27, 2023 17:11 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-getting-started-qh25mj October 3, 2023 13:46 Inactive
@restyled-io restyled-io bot mentioned this pull request Oct 3, 2023
Merged
@restyled-io @restyled-commits
Restyled by prettier (#4896)
1af6653 
Co-authored-by: Restyled.io <commits@restyled.io>
@shcheklein shcheklein temporarily deployed to dvc-org-getting-started-qh25mj October 3, 2023 13:59 Inactive
@tibor-mach
Revert "trying out webm"
a8f4056 
This reverts commit 95967d1.
@shcheklein shcheklein temporarily deployed to dvc-org-getting-started-qh25mj November 16, 2023 15:25 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-getting-started-qh25mj November 16, 2023 15:56 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-getting-started-qh25mj November 16, 2023 16:28 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-getting-started-qh25mj November 16, 2023 16:39 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-getting-started-qh25mj November 16, 2023 16:44 Inactive
dberenbaum
dberenbaum requested changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@dberenbaum dberenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put a couple suggestions where changes are needed. Nothing else is a blocker, so once you commit those and the example repo is ready, we could merge.

content/docs/start/model-management/model-registry.md Show resolved Hide resolved
content/docs/start/model-management/model-cicd.md Show resolved Hide resolved
content/docs/start/model-management/model-cicd.md Show resolved Hide resolved
content/docs/start/model-management/model-cicd.md Outdated Show resolved Hide resolved
content/docs/start/model-management/model-cicd.md Outdated Show resolved Hide resolved
content/docs/start/model-management/model-cicd.md Outdated Show resolved Hide resolved
content/docs/start/model-management/model-cicd.md Outdated Show resolved Hide resolved
@tibor-mach tibor-mach mentioned this pull request Nov 16, 2023
Closed
@tibor-mach @dberenbaum
Apply suggestions from code review
ca7f444 
Co-authored-by: Dave Berenbaum <dave.berenbaum@gmail.com>
@shcheklein shcheklein temporarily deployed to dvc-org-getting-started-qh25mj November 16, 2023 21:11 Inactive
@restyled-io restyled-io bot mentioned this pull request Nov 16, 2023
Merged
@restyled-io @restyled-commits
Restyled by prettier (#4991)
7700f9d 
Co-authored-by: Restyled.io <commits@restyled.io>
@shcheklein shcheklein temporarily deployed to dvc-org-getting-started-qh25mj November 16, 2023 21:16 Inactive
@dberenbaum
Copy link
Collaborator

dberenbaum commented Nov 16, 2023 •
edited
Loading

@tibor-mach Let's make sure the repo changes deploy correctly. Then I think we are ready to merge! 🎉

Edit: I mean here

@shcheklein shcheklein temporarily deployed to dvc-org-getting-started-qh25mj November 16, 2023 21:33 Inactive
@restyled-io restyled-io bot mentioned this pull request Nov 16, 2023
Merged
@restyled-io @restyled-commits
Restyled by prettier (#4992)
e87d4c3 
Co-authored-by: Restyled.io <commits@restyled.io>
@shcheklein shcheklein temporarily deployed to dvc-org-getting-started-qh25mj November 16, 2023 21:36 Inactive
@tibor-mach tibor-mach removed the ⌛ status: wait-core-merge Waiting for related product PR merge/release label Nov 16, 2023
@tibor-mach tibor-mach merged commit c2740b1 into main Nov 16, 2023
5 checks passed
@tibor-mach tibor-mach deleted the getting-started-mr branch November 16, 2023 21:48
@tibor-mach
Copy link
Contributor Author

@SoyGema Thank you for participation in this PR. It is now merged, but if you'd like to help it would be great if you tried to follow the guide and potentially gave us feedback on that.

@SoyGema
Copy link
Contributor

SoyGema commented Nov 16, 2023

[1] [2] [3][4][5] Hmmm. [6][7] No [8]

@tibor-mach tibor-mach mentioned this pull request Nov 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoyGema SoyGema SoyGema left review comments

@dberenbaum dberenbaum dberenbaum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tibor-mach @dberenbaum @SoyGema @jendefig @shcheklein