Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regular doc updates (early Dec) #846

Merged
merged 21 commits into from
Dec 12, 2019
Merged

Regular doc updates (early Dec) #846

merged 21 commits into from
Dec 12, 2019

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Dec 9, 2019 •
edited
Loading

@shcheklein shcheklein temporarily deployed to dvc-org-pr-846 December 9, 2019 18:28 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 9, 2019 19:58 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 9, 2019 20:46 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 9, 2019 23:08 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 9, 2019 23:13 Inactive
shcheklein
shcheklein reviewed Dec 9, 2019
View reviewed changes
src/Diagram/index.js Outdated Show resolved Hide resolved
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 9, 2019 23:26 Inactive
shcheklein
shcheklein approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, good to merge

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 10, 2019 01:25 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 10, 2019 01:35 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 10, 2019 01:38 Inactive
@jorgeorpinel

This comment has been minimized.

Sign in to view
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 10, 2019 18:50 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 10, 2019 19:16 Inactive
@jorgeorpinel jorgeorpinel changed the title [WIP] regular doc updates Regular doc updates (early Dec) Dec 10, 2019
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 10, 2019 22:54 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 10, 2019 23:47 Inactive
shcheklein
shcheklein reviewed Dec 11, 2019
View reviewed changes
pages/api/comments.js Outdated Show resolved Hide resolved
shcheklein
shcheklein requested changes Dec 11, 2019
View reviewed changes
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. A few minor comments/questions.

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 11, 2019 23:33 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 11, 2019 23:51 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 11, 2019 23:56 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 12, 2019 00:06 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 12, 2019 00:11 Inactive
shcheklein
shcheklein approved these changes Dec 12, 2019
View reviewed changes
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! feel free to merge!

@jorgeorpinel
Copy link
Contributor Author

Thanks!

@jorgeorpinel jorgeorpinel merged commit d43a835 into master Dec 12, 2019
@weekly-digest weekly-digest bot mentioned this pull request Dec 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiop efiop efiop left review comments

@shcheklein shcheklein shcheklein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jorgeorpinel @shcheklein @efiop