-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remote: use -d
in s3 example
#902
Conversation
User complained that local one has `-d` but s3 doesn't.
Thinking about it, I'm not sure why we wanted to change this example over a single user's feedback. I think having significantly different examples is a good thing. Maybe we should revert? |
@jorgeorpinel Not worth reverting in my opinion. This PR just made it consistent within one doc. I think that complaint was a reasonable one. |
Understood, but I've already rewritten the examples of that doc anyway, please see #915 (review). Thanks! |
User complained that local one has
-d
but s3 doesn't.Disregard the recommendations below if you use Edit on GitHub button to improve the docs in place.
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue
(if applicable) in the description of the PR. This enables GitHub to link the PR to the corresponding bug and close it automatically when PR is merged.Thank you for the contribution - we'll try to review and merge it as soon as possible. 🙏