Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: regular updates (mid Jan) #915

Merged
merged 25 commits into from
Jan 19, 2020
Merged

doc: regular updates (mid Jan) #915

merged 25 commits into from
Jan 19, 2020

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Jan 12, 2020

Misc. stuff +

@shcheklein shcheklein temporarily deployed to dvc-landing-jorgeorpine-dmwslo January 12, 2020 03:04 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorgeorpine-dmwslo January 12, 2020 19:14 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorgeorpine-dmwslo January 12, 2020 19:30 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorgeorpine-dmwslo January 12, 2020 19:33 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorgeorpine-dmwslo January 12, 2020 20:11 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorgeorpine-dmwslo January 13, 2020 21:29 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorgeorpine-dmwslo January 13, 2020 22:26 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorgeorpine-dmwslo January 14, 2020 01:10 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorgeorpine-dmwslo January 14, 2020 02:33 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorgeorpine-dmwslo January 14, 2020 19:13 Inactive
server.js Outdated Show resolved Hide resolved
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorgeorpine-dmwslo January 16, 2020 01:07 Inactive
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go, just a few comments. thanks 🎉

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorgeorpine-dmwslo January 16, 2020 17:20 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorgeorpine-dmwslo January 16, 2020 17:47 Inactive
pages/doc.js Outdated Show resolved Hide resolved
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorgeorpine-dmwslo January 16, 2020 19:48 Inactive
import ReactMarkdown from 'react-markdown'
import { LightButton } from '../LightButton'
import Tutorials from '../Tutorials'
import Tooltip from '../../Tooltip'
import Collapsible from 'react-collapsible'
// syntax highlighter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here - let's not do this right now. Let's postpone cosmetic JS changes please and wait for @iAdramelk to wrap up the two major branches.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean not to remove those unnecessary comments? I thought we agreed to remove them. Should I bring them back? Up to you, but I think a simple removal like this is very unlikely to produce merge conflicts.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I mean not do a lot of cosmetic changes to JS at this moment. We can do it later. It might create conflicts for @iAdramelk for no good reason.

Copy link
Contributor Author

@jorgeorpinel jorgeorpinel Jan 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK... Reverted https://github.com/iterative/dvc.org/compare/4950d25..7ea2edb in c64d590. This is the 2nd time these changes get reverted so I'll just forget about this until/if someone else brings it up 😋

server.js Outdated Show resolved Hide resolved
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check a few comments - otherwise looks good to me.

Revert "es6: remove comments between import groups throughout"

with git revert 6ac834e^..7ea2edb (and then squash)
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorgeorpine-dmwslo January 18, 2020 19:41 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorgeorpine-dmwslo January 18, 2020 19:46 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorgeorpine-dmwslo January 18, 2020 19:50 Inactive
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

user-guide: improve Windows POSIX/terminal tips
2 participants