-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dvc: update file utilities #2137
Labels
good first issue
p3-nice-to-have
It should be done this or next sprint
refactoring
Factoring and re-factoring
Comments
efiop
added
p2-medium
Medium priority, should be done, but less important
refactoring
Factoring and re-factoring
labels
Jun 17, 2019
2 tasks
efiop
added
p4-not-important
and removed
p2-medium
Medium priority, should be done, but less important
labels
Jul 23, 2019
efiop
added
p3-nice-to-have
It should be done this or next sprint
and removed
p4
labels
Sep 25, 2019
For the record, this one is taken by @algomaster99 . Not able to assign yet, working on adding him to organization. |
This was referenced Oct 26, 2019
This was referenced Nov 5, 2019
This was referenced Nov 14, 2019
3 tasks
@MrOutis Not yet, as you can see there are still things like |
This was referenced Jan 1, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
p3-nice-to-have
It should be done this or next sprint
refactoring
Factoring and re-factoring
Some file utilities live in
dvc.utils.fs
while some other indvc.utils.__init__
. I suggest grouping them in a single place.Also, some of them accept Path-like objects, i.e.
Path
,PurePath
,PathInfo
, etc and some do not. This makes people guess at the call site whether they need to wrap arguments intofspath()
,fspath_py35()
or none. So I propose that our file utilities will always accept that, this way we will concentrate those wrapper call in one place and remove the guessing part, at least for our own functions, callingos.path.*()
will still need wrapping as long as we use Python 3.5-.dvc.utils.fs
(Fixed by Move fs utilities to fs.py from __init__.py #3093 )get_inode
#2673 Verify ifget_mtime_and_size
can take both Path objects and strings #2698 Ensurecontains_symlink_up_to
accept both str and Path-like objects #2740 Ensurefile_md5
accept str and Path-like objects #2746 Ensurecopyfile
accepts str and Path-like objects #2752 Ensuremakedirs
accepts str and Path-like objects #2757 Ensuremove
accepts str and Path-like objects #2769 Ensureremove
accepts str and Path-like objects #2795 Write test fortmp_fname
to check if it accepts Path-like and str objects #2808 Write test forwalk_files
to check if it accepts Path-like and str objects #3035 Ensurerelpath
accepts str and Path-like objects #3037 )The text was updated successfully, but these errors were encountered: