Write test for get_inode

[algomaster99]

• Have you followed the guidelines in our
  Contributing document?

• Does your PR affect documented changes or does it add new functionality
  that should be documented? If yes, have you created a PR for
  dvc.org documenting it or at
  least opened an issue for it? If so, please add a link to it.

---

With reference to #2137
Testing if get_inode can take both - Path-like objects and strings.

[algomaster99]

@efiop
https://github.com/iterative/dvc/blob/1baf020de7c3b0024807f30bc7e9eec39a37948c/dvc/state.py#L376
Does this function accept both ways too?

I thought I would delete https://github.com/iterative/dvc/blob/1baf020de7c3b0024807f30bc7e9eec39a37948c/dvc/state.py#L373 because we were replacing get_inode(path) with get_inode(path_info) but since the above function uses it, I didn't.

[algomaster99]

@efiop The DeepSource test failed because I unnecessarily used dvc_repo but it's passed as an argument in one of the functions in test_version.py too but never used so how should I make the test pass?

[efiop]

You are not mocking anything in this test

Suggested change

# Mocking a file to get the inode.

[algomaster99]

@efiop I am creating a file FOO so that I can mock a path. Isn't this called mocking?

[efiop]

Mocking is when you simulate something, and here you are testing on a real file, so I wouldn't call that mocking.

[algomaster99]

@efiop Oh okay. But how does it delete the file later?

[algomaster99]

@efiop Can you answer this, please? :)

[efiop]

@algomaster99 Sorry, missed this. Yes, it deletes it. See dvc_repo fixture in tests/conftest.py.

[efiop]

Please see comments above

[efiop]

Does this function accept both ways too?

Yes, it should accept both str and path_info too, but let's fix it in a separate PR 🙂

. because we were replacing get_inode(path) with get_inode(path_info) but since the above function uses it, I didn't.

Got it. Yes, this PR is mergable by itself so let's finish this and proceed with get_mtime_and_size next, in shich we would be able to remove fspath_py35 from that method in state.py.

[efiop]

Looks good! Let's remove that comment and we will be ready to merge 🙂

[efiop]

Perfect! Thanks! 🎉