-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce artifacts:
section in DVC and make it work with GTO
#9219
Comments
Thanks @aguschin, sounds like a good plan, overall. A few questions:
can we cut the scope? is it needed?
does it make sense to start with this? Do we need to include an item that simplifies GTO? (removes the registry files mechanics). |
Maybe we can, but I'm trying to find a way to not break current users workflows. GTO don't have that many users, and I wouldn't like to lose them. This item can be postponed though - there will be some time before we implement this, and before we release it. So we can prioritize other things and get back to it before the release. Not mentioning some users asking for that specifically. Re how we can avoid breaking user workflows though. When we support
IIRC, @dberenbaum wanted to take it and add to DVC docs? Although I had an impression there are some WIP changes proposed by @daavoo. Happy to help there if needed - writing docs is so much faster for me than implementing this in DVC (for now 😅 ). |
@shcheklein I added iterative/dvc.org#4423 to discuss docs. Since @aguschin already drafted iterative/mlem.ai#323, is there something missing from there that you'd like to see before implementation?
I asked @aguschin the same thing 😄, and he explained that he will try to do it to make it easier for existing users to transition if it's low effort. I do worry about documenting this and making |
Folks, we need to be extra extra mindful about complexity and scope. Can we help the existing users (and we don't have many, right?) to transition to the new format manually, of with some small written instruction? Complicating parsing in Studion, dvc.yaml format, etc - doesn't unfortunately sound like a very easy thing to do. I feel your concerns and I like the deep care to the users though @aguschin !!
I don't know (your call), I was asking specifically because it sometimes uncovers more things. If you feel that it's stable already, we get sense for all the changes, etc - we good to go then. |
@aguschin We are aiming to include this as part of a 3.0 release at the end of this quarter. Do you expect that we can get all of the items above done? Do you think there is more that needs to be added before release? |
@dberenbaum, yes, I'm sure we'll get it done. And it looks like top issue's comment has all items to do. |
…346) Related to iterative/dvc#9219 One question I'd like to discuss: instead of removing `gto describe` (and maybe `gto annotate` and `gto remove`), we could keep them. At least for `describe` it's pretty trivial to support - we can call DVC API to read annotations. Also this can be helpful if we're planning to implement the command in DVC - here we can implement and check it works and satisfies user needs.
Summary / Background
To make working with Model Registry (including Studio MR) more accessible for DVC users, we merge
artifacts.yaml
into DVC. More detail discussion on this iterative/gto#337Release scope
Described in iterative/mlem.ai#323, but summarizing it here. For now I'm excluding what we considered to be extra features (they can be found in docs proposal marked as
[extra for now]
):registry:
section and exposing for API user (Studio) Add top-levelartifacts:
section #9220dvc.yaml
completely, e.g.registry: artifacts.yaml
Add top-levelartifacts:
section #9220artifacts
section dvclive#519example-gto
repo and other fixture repos for Studio BEexample-gto
: removeannotate
and move artifacts todvc.yaml
example-repos-dev#192artifacts.yaml
part from GTO Removeartifacts.yaml
part in favor ofartifacts:
section in DVC gto#346artifacts:
section to the schema dvcyaml-schema#36Follow-ups after release (p1)
Follow-ups after release (p2)
dvc get $REPO myartifact#prod
Download models (type: model
) withdvc get
#9100#prod
or@latest
with DVC APIdvc exp
workflow together with MR #9102dvc import
for artifacts same way we should supportdvc get
alreadyRelated issues
artifacts
piece @skshetry implemented already Meta information for data #8214 add metadata fields: label, type to data #8232The text was updated successfully, but these errors were encountered: