-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
limit pytest version to <8.1 #10334
limit pytest version to <8.1 #10334
Conversation
Change in pytest==8.1.0 breaks `flaky` plugin. See box/flaky#198.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10334 +/- ##
==========================================
- Coverage 90.60% 90.22% -0.39%
==========================================
Files 500 500
Lines 38591 38591
Branches 5573 5564 -9
==========================================
- Hits 34965 34818 -147
- Misses 2983 3081 +98
- Partials 643 692 +49 ☔ View full report in Codecov by Sentry. |
Will we detect when there is a fix available? |
The change is intentional in |
yep, but how will we know to bump it again? will there be a dependabot PR? |
I will revert this PR once the issue gets fixed. And, yes there will be dependabot PR for newer pytest releases. But the problem is not with pytest, but with flaky. |
yep, I got that part. Was to double check that we have a way to get back to it via some automated PR. Thanks @skshetry . |
* Revert "limit pytest version to <8.1 (#10334)" This reverts commit bc95b65. * replace flaky with pytest-rerunfailures `flaky` project seems to be unmaintained (see box/flaky#192). `pytest-rerunfailures` seems to be maintained under `pytest-dev` and tests 5 minor releases of pytest. Note that this plugin is not compatible with `flaky` plugin. You will have to uninstall it if it exists.
FWIW, given that |
Thanks @The-Compiler for the suggestion. I have replaced |
Change in pytest==8.1.0 breaks `flaky` plugin. See box/flaky#198.
* Revert "limit pytest version to <8.1 (iterative#10334)" This reverts commit bc95b65. * replace flaky with pytest-rerunfailures `flaky` project seems to be unmaintained (see box/flaky#192). `pytest-rerunfailures` seems to be maintained under `pytest-dev` and tests 5 minor releases of pytest. Note that this plugin is not compatible with `flaky` plugin. You will have to uninstall it if it exists.
Changes in pytest==8.1.0 breaks
flaky
plugin.See box/flaky#198.
It's breaking the CI.