Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: diff: handle deleted/new metric #3529

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Mar 25, 2020

Partial fix for #3469

  • ❗ I have followed the Contributing to DVC checklist.

  • πŸ“– If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

@efiop efiop changed the title metrics: diff: handle deleted/new metric [WIP] metrics: diff: handle deleted/new metric Mar 25, 2020
@efiop efiop added the p0-critical Critical issue. Needs to be fixed ASAP. label Mar 25, 2020
@efiop efiop changed the title [WIP] metrics: diff: handle deleted/new metric metrics: diff: handle deleted/new metric Mar 25, 2020
@efiop efiop merged commit 0bf6fda into iterative:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p0-critical Critical issue. Needs to be fixed ASAP.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant