dvc: separate cache and tree hashes #4511
Conversation
|
|
||
| hi, tmp_info = self._get_dir_info_hash(dir_info) | ||
| if hash_info: | ||
| assert hi == hash_info |
There was a problem hiding this comment.
Will go away in the next PR when we support md5s for external dirs. Just a sanity check for now.
efiop
changed the title
efiop
changed the title
| @@ -7,6 +7,7 @@ | |||
| class HashInfo: | |||
| name: str | |||
| value: str | |||
| dir_info: list = field(default=None, compare=False) | |||
There was a problem hiding this comment.
Is it possible to have a non-nullable HashInfo, i.e. without name and value being None?
I understand that it's just a simple container, but I want to avoid possibilities of hash_info being:
None- A regular hash_info
- hash_info with
value=None.
1 and 2 are fine, it'd be safer to avoid 3rd case if we can.
There was a problem hiding this comment.
Is it possible to have a non-nullable HashInfo, i.e. without name and value being None?
@skshetry it is not, but we allow it. Very good points! I also thought about it, but decided not to mess with it for now. Ideally thinking about making this dataclass read-only, so everything will be set when creating an instance and so we can put appropriate checks/asserts for such things
Related to #4144 , #3069 , #1676
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏