logging: change from dictConfig to equivalent code for creating logge… (#8985 #8985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs/handlers/formatters dictConfig clears all handlers, and potentially disables existing loggers (we disabled this functionality though). There's much more code than necessary in dictConfig than what we need. I have tried to keep the setup equivalent to what we had in the config, so I have not tried to cleanup the code.
Codecov ReportBase: 93.08% // Head: 93.08% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #8985 +/- ##
==========================================
- Coverage 93.08% 93.08% -0.01%
==========================================
Files 455 455
Lines 36695 36705 +10
Branches 5300 5300
==========================================
+ Hits 34158 34167 +9
- Misses 2020 2021 +1
Partials 517 517
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Need to test this on google colab and jupyter notebook. |
|
Okay, this looks good. Tested on jupyter, and it works. The output won't be colored, as |
skshetry
changed the title
skshetry
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rs/handlers/formatters
dictConfig clears all handlers, and potentially disables existing loggers (we disabled this functionality though). There's much more code than necessary in dictConfig than what we need.
I have tried to keep the setup equivalent to what we had in the config, so I have not tried to cleanup the code.